Bug 1954004

Summary:	Review Request: perl-JSON-Create - Create JSON
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Emmanuel Seyman <emmanuel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	emmanuel, package-review
Target Milestone:	---	Flags:	emmanuel: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-JSON-Create-0.32-1.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-05 14:16:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2021-04-27 12:17:06 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-JSON-Create/perl-JSON-Create.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-JSON-Create/perl-JSON-Create-0.32-1.fc35.src.rpm
Description:
JSON::Create encodes Perl variables into JSON. The basic routine "create_json"
gives common defaults. The stricter version "create_json_strict" accepts only
unambiguous inputs. For more customization, an object created with "new" and
run with "create" allows specifying behavior in more detail.

Fedora Account System Username: ppisar

Comment 1 Emmanuel Seyman 2021-04-29 08:05:12 UTC

The tests included in the distribution fail to run because the spec file does not build-require perl(Test::More).
Petr, can you fix this before I continue with the review?

Comment 2 Petr Pisar 2021-04-29 13:54:31 UTC

Mea culpa. The corrected package is on the same address.

Comment 3 Petr Pisar 2021-04-29 13:57:35 UTC

I've just added also File::Temp and File::Spec required by a patch.

Comment 4 Emmanuel Seyman 2021-05-04 19:13:05 UTC

Description verified from lib/JSON/Create.pod. Ok.
License verified from Makefile.PL, and lib/JSON/Create.pod. Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint *.spec /var/lib/mock/fedora-rawhide-x86_64/result/
perl-JSON-Create-tests.noarch: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 1 warnings.
rpmlint output is Ok.

File layout and permissions are Ok.

$ rpm -q --requires -p  perl-JSON-Create-0.32-1.fc35.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.32()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(B)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(JSON::Parse) >= 0.60
      1 perl(parent)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Unicode::UTF8) >= 0.62
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
      1 rtld(GNU_HASH)
Binary Requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Lib-0.002-1.fc35.noarch.rpm | sort -f | uniq -c
      1 perl(JSON::Create) = 0.32
      1 perl(JSON::Create::Bool) = 0.32
      1 perl(JSON::Create::PP) = 0.32
      1 perl-JSON-Create = 0.32-1.fc35
      1 perl-JSON-Create(x86-64) = 0.32-1.fc35
Binary Provides are Ok.

The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=67220547). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 5 Petr Pisar 2021-05-05 08:14:04 UTC

https://pagure.io/releng/fedora-scm-requests/issue/33805

Comment 6 Petr Pisar 2021-05-05 14:06:29 UTC

Thank you for the review and the repository.