Bug 1954177

Summary: machine-api: admissionReviewVersions v1beta1 is going to be removed in 1.22
Product: OpenShift Container Platform Reporter: Stefan Schimanski <sttts>
Component: Cloud ComputeAssignee: Michael McCune <mimccune>
Cloud Compute sub component: Other Providers QA Contact: sunzhaohua <zhsun>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: mimccune
Version: 4.8   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1954187 (view as bug list) Environment:
Last Closed: 2021-07-27 23:04:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1954184    

Description Stefan Schimanski 2021-04-27 18:05:06 UTC
Description of problem:

machine-api admission webhook uses admissionReviewVersions v1beta1.

Steps to Reproduce:
1. kubectl get mutatingwebhookconfigurations.admissionregistration.k8s.io -o yaml
2. check webhooks[*].admissionReviewVersions

Expected results:
v1

Comment 1 Stefan Schimanski 2021-04-27 18:07:35 UTC
mutatingwebhookconfiguration name is machine-api.

Comment 2 Stefan Schimanski 2021-04-27 18:11:03 UTC
Same for pod-identity-webhook mutatingwebhookconfiguration.

Comment 3 Stefan Schimanski 2021-04-27 18:20:34 UTC
Same for autoscaling.openshift.io.

Comment 4 Michael McCune 2021-04-27 21:43:26 UTC
(In reply to Stefan Schimanski from comment #3)
> Same for autoscaling.openshift.io.

i'm not seeing any references to the admissionReviewVersions in our cluster-autoscaler or operator, are there any more details about this?

Comment 5 Joel Speed 2021-04-28 09:53:02 UTC
There is already a PR in flight for the CAO changes that are required here, but it is not ready to merge just yet https://github.com/openshift/cluster-autoscaler-operator/pull/202

Comment 7 Michael McCune 2021-05-04 15:10:11 UTC
i am setting this back to ASSIGNED status, there are a few more patches required to finish this. mainly the machine-api-operator needs to be re-vendored back to the providers and testing repositories.

Comment 9 sunzhaohua 2021-05-20 03:27:44 UTC
$  oc get ValidatingWebhookConfiguration multus.openshift.io -o yaml | grep admissionReviewVersions -A 1
- admissionReviewVersions:
  - v1

Comment 12 errata-xmlrpc 2021-07-27 23:04:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438