Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1954427

Summary: [CBT] Image transfer cannot be stopped after failed to download missing backup disk
Product: [oVirt] ovirt-engine Reporter: Eyal Shenitzky <eshenitz>
Component: BLL.StorageAssignee: Mark Kemel <mkemel>
Status: CLOSED CURRENTRELEASE QA Contact: Evelina Shames <eshames>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.4.5CC: ahadas, bugs, dfodor, imarkelo
Target Milestone: ovirt-4.5.1Keywords: Reopened, ZStream
Target Release: ---Flags: sbonazzo: ovirt-4.5-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.5.1.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-27 07:10:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1952916    
Bug Blocks:    
Attachments:
Description Flags
logs none

Description Eyal Shenitzky 2021-04-28 07:28:19 UTC
Description of problem:

The image transfer fails if the user tries to download an incremental backup that was created for a RAW disk with a snapshot (that allows to mark the disk as backup enabled) and deleted a snapshot before the download.

Version-Release number of selected component (if applicable):
ovirt-4.4.5
vdsm-4.40.50.10-1.el8ev.x86_64
ovirt-imageio-daemon-2.1.1-1.el8ev.x86_64
libvirt-daemon-6.6.0-13.2.module+el8.3.1+10483+85317cf0.x86_64
qemu-kvm-5.1.0-21.module+el8.3.1+10464+8ad18d1a.x86_64

How reproducible:
1. Create a VM with RAW disk
2. take a snapshot
3. Enable incremental backup option for the RAW disk
4, Make a full backup
5. Make an incremental backup
6. Delete the snapshot
7. Try to download the incremental or the full backup. 

Actual results:
Download failed due to missing ticket

Expected results:
A proper error should be raised.

Additional info:
2021-04-23 15:07:09,806+02 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.StartNbdServerVDSCommand] (default task-276) [e1d58a42-e58b-4e65-8e56-4e385b45d404] Failed in 'StartNbdServerVDS' method
2021-04-23 15:07:09,806+02 WARN  [org.ovirt.engine.core.vdsbroker.vdsbroker.StartNbdServerVDSCommand] (default task-276) [e1d58a42-e58b-4e65-8e56-4e385b45d404] Unexpected return value: Status [code=2009, message=Unsupported operation: 'reason=Cannot export bitmap from RAW volume, context={}']
2021-04-23 15:07:09,815+02 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-276) [e1d58a42-e58b-4e65-8e56-4e385b45d404] EVENT_ID: VDS_BROKER_COMMAND_FAILURE(10,802), VDSM pan-rhv44rel1 command StartNbdServerVDS failed: Unsupported operation: 'reason=Cannot export bitmap from RAW volume, context={}'

After unsuccessful download the engine tries to close the ticket, but can't do that

Failed to stop image transfer session. Ticket does not exist for image '4c23c18c-7804-4850-a5d1-41391fdc4482'

Comment 1 Eyal Shenitzky 2021-04-28 07:29:08 UTC
Created attachment 1776387 [details]
logs

Comment 3 Michal Skrivanek 2022-04-11 08:50:07 UTC
No update for a while, didn't make it in time for 4.5, closing

Comment 4 Arik 2022-04-27 12:54:40 UTC
Might be solved already by the fix for bz 2068104
but we're not sure and as it seems to be a valid scenario in an area that we have been working on lately, we'd like to give it a try and see if it still happens

Comment 5 Arik 2022-05-24 14:12:08 UTC
We discussed this offline and agreed that the way to go is to block snapshot removal while there is an ongoing backup

Comment 6 Ilia Markelov 2022-06-23 14:10:21 UTC
Verified.

Snapshot removal is blocked with the proper error while there is an ongoing backup.

Versions:
engine-4.5.1.2-0.11.el8ev
vdsm-4.50.1.3-1.el8ev.x86_64