Bug 1954505

Summary: [RFE] Better to have an output message when virtctl addvolume/removevolume to a VM
Product: Container Native Virtualization (CNV) Reporter: Yan Du <yadu>
Component: StorageAssignee: Alexander Wels <awels>
Status: CLOSED ERRATA QA Contact: Yan Du <yadu>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.8.0CC: alitke, cnv-qe-bugs, mrashish
Target Milestone: ---   
Target Release: 4.9.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubevirt-virtctl-4.9.2-309.el8.x86_64.rpm Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-19 17:49:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yan Du 2021-04-28 09:51:33 UTC
Description of problem:
[RFE] Better to have an output message when virtctl addvolume/removevolume to a VM

Version-Release number of selected component (if applicable):
CNV4.8
virtctl-4.8.0-200.el7.x86_64.rpm

How reproducible:
Always

Steps to Reproduce:
1. Try to add/remove a volume to a VM
2.
3.

Actual results:
[cnv-qe-jenkins@yadu1-ft7t7-executor]$ virtctl addvolume fedora-1619603152-2246912 --volume-name=blank-dv
[cnv-qe-jenkins@yadu1-ft7t7-executor]$

[cnv-qe-jenkins@yadu1-ft7t7-executor]$ virtctl removevolume fedora-1619603152-2246912 --volume-name=blank-dv
[cnv-qe-jenkins@yadu1-ft7t7-executor]$ 


Expected results:
After executing the virtctl addvolume/removevolume cmd, it would be more friendly to user if there is an output message like
"Adding volume for the VM/VMI"
or 
"Removing volume for the VM/VMI"

Additional info:

Comment 1 Adam Litke 2021-04-28 13:00:44 UTC
It sounds like it might be nice to have a --wait mode where the command waits for the volume to transition to attached state and even prints out some of the progression of steps.

Comment 2 Adam Litke 2021-11-08 15:37:03 UTC
Alexander I do not see this in virtctl.  If you disagree, please link to the pr.

Comment 3 Yan Du 2021-12-20 06:21:48 UTC
Test on CNV-v4.9.2-11
virtctl Client Version: version.Info{GitVersion:"v0.44.3-44-g9150a3b90", GitCommit:"9150a3b909d345835f84ec7d06c6e6ff8f0b8855", GitTreeState:"clean", BuildDate:"2021-12-16T04:15:09Z", GoVersion:"go1.15.14", Compiler:"gc", Platform:"linux/amd64"}

$  virtctl addvolume fedora-1619697674-6212 --volume-name=blank-dv
Successfully submitted add volume request to VM fedora-1619697674-6212 for volume blank-dv

$ virtctl removevolume fedora-1619697674-6212 --volume-name=blank-dv
Successfully submitted remove volume request to VM fedora-1619697674-6212 for volume blank-dv

Comment 9 errata-xmlrpc 2022-01-19 17:49:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.9.2 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0191