Bug 1954747

Summary: Bug fixes for Collection/Automation Hub
Product: Red Hat Enterprise Linux 8 Reporter: Noriko Hosoi <nhosoi>
Component: rhel-system-rolesAssignee: Noriko Hosoi <nhosoi>
Status: CLOSED ERRATA QA Contact: David Jež <djez>
Severity: unspecified Docs Contact: Eliane Ramos Pereira <elpereir>
Priority: unspecified    
Version: 8.5CC: briasmit, djez, elpereir, nhosoi, rmeggins, spetrosi
Target Milestone: betaKeywords: Triaged
Target Release: 8.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rhel-system-roles-1.2.2-3.el8 Doc Type: Bug Fix
Doc Text:
.The `requirements.txt` file no longer missing in the Ansible collection Previously, the `requirements.txt` file, responsible for specifying the python dependencies, was missing in the Ansible collection. This fix adds the missing file with the correct dependencies at the `/usr/share/ansible/collections/ansible_collections/redhat/rhel_system_roles/requirements.tx` path.
Story Points: ---
Clone Of:
: 1957484 (view as bug list) Environment:
Last Closed: 2021-11-09 17:45:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1957484    

Description Noriko Hosoi 2021-04-28 17:48:59 UTC
Description of problem:
This bz covers multiple of bug fixes.

1. nbde_client - broken README.md due to the Automation Hub renderer.

    https://github.com/linux-system-roles/nbde_client/pull/46
    README.md - Adding a blank line after nbde_client_bindings -- merged

    VERIFICATION STEPS:
    Import the fixed nbde_client to AH and render the README.md.

2. SAP issue - lsr_role2collection.py does not convert the legacy role path 
   if the role is not the one to be converted.

    https://github.com/linux-system-roles/auto-maintenance/issues/65
    https://github.com/linux-system-roles/auto-maintenance/pull/68

    VERIFICATION STEPS:
    Convert sap-hana-preconfigure to the collection format using 
    lsr_role2collection.py having the pr/68 fix with the option
    --extra-mapping "timesync:redhat.rhel_system_roles.timesync,sap-base-settings:sap-base-settings,sap-preconfigure:sap-preconfigure"
    Check the converted README.md to have:
      - 'redhat.rhel_system_roles.timesync'
      - 'microsoft.rhel.sap-base-settings' (for RHEL 7.x until RHEL 7.5)
      - 'microsoft.rhel.sap-preconfigure' (for RHEL 7.6 and later and RHEL 8.x)
          - { role: microsoft.rhel.sap-base-settings }
          - { role: microsoft.rhel.sap-hana-preconfigure }
    Note: the namespace and the collection name of SAP might not be accurate.
    Before verifying this bug fix, please get the accurate names.
    

3. Collections - add requirements.txt, bindep.txt for requirements 
   [RHELPLAN-76440]

    https://github.com/linux-system-roles/auto-maintenance/pull/69
    Improve dependencies in the packaging #69

    https://src.fedoraproject.org/rpms/linux-system-roles/pull-request/7#
    #7 collections - add requirements.txt, bindep.txt for requirements

    VERIFICATION STEPS:
    Install rhel-system-roles rpm package and check this file exists.
    /usr/share/ansible/collections/ansible_collections/redhat/rhel_system_roles/requirements.txt
    and it contains these python dependencies:
    ==> /usr/share/ansible/collections/ansible_collections/redhat/rhel_system_roles/requirements.txt <==
    jmespath
    netaddr

Comment 1 Noriko Hosoi 2021-04-28 18:13:58 UTC
A correction: the item 2 "SAP issue" should be separated as it does not belong to the "rhel-system-roles package".

Comment 5 Rich Megginson 2021-05-18 00:30:40 UTC
@nhosoi Can you provide the verification steps?

Comment 22 errata-xmlrpc 2021-11-09 17:45:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4159