Bug 1955196

Summary:	linuxptp-daemon crash on 4.8
Product:	OpenShift Container Platform	Reporter:	Sebastian Scheinkman <sscheink>
Component:	Networking	Assignee:	Sebastian Scheinkman <sscheink>
Networking sub component:	ptp	QA Contact:	Nikita <nkononov>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	high	CC:	dosmith, huirwang, nkononov, zzhao
Version:	4.8
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 23:04:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1995579

Description Sebastian Scheinkman 2021-04-29 16:47:04 UTC

Description of problem:

latest rhcos image contains a new ethtool version that change the output for the `-T --show-time-stamping ` option and that cause the Linuxptp-daemon to crash with panic

output:

I0429 09:44:03.041764  157851 utils.go:68] grabbing NIC timestamp capability for ede735fcddbb336
I0429 09:44:03.042305  157851 utils.go:34] cmd output for Time stamping parameters for ede735fcddbb336:
Capabilities:
	software-transmit
	software-receive
	software-system-clock
PTP Hardware Clock: none
Hardware Transmit Timestamp Modes: none
Hardware Receive Filter Modes: none
I0429 09:44:03.042315  157851 utils.go:68] grabbing NIC timestamp capability for eno1
I0429 09:44:03.042919  157851 utils.go:34] cmd output for Time stamping parameters for eno1:
Capabilities:
	hardware-transmit
	hardware-receive
	hardware-raw-clock
PTP Hardware Clock: 2
Hardware Transmit Timestamp Modes:
	off
	on
Hardware Receive Filter Modes:
	none
	all
panic: runtime error: index out of range [1] with length 1

goroutine 80 [running]:
github.com/openshift/linuxptp-daemon/pkg/network.netParseEthtoolTimeStampFeature(0xc000806000, 0x0)
	/go/src/github.com/openshift/linuxptp-daemon/pkg/network/utils.go:43 +0x4ba
github.com/openshift/linuxptp-daemon/pkg/network.DiscoverPTPDevices(0x0, 0x12dfca0, 0xc0001aa410, 0xc0000e7ef0, 0x4e)
	/go/src/github.com/openshift/linuxptp-daemon/pkg/network/utils.go:76 +0x2e5
github.com/openshift/linuxptp-daemon/pkg/daemon.runDeviceStatusUpdate(0xc000591c10, 0xc00004604a, 0x27)
	/go/src/github.com/openshift/linuxptp-daemon/pkg/daemon/ptpdev.go:34 +0x34
github.com/openshift/linuxptp-daemon/pkg/daemon.RunDeviceStatusUpdate(0xc000591c10, 0xc00004604a, 0x27)
	/go/src/github.com/openshift/linuxptp-daemon/pkg/daemon/ptpdev.go:64 +0xc5
created by main.main
	/go/src/github.com/openshift/linuxptp-daemon/cmd/main.go:68 +0x4aa

Comment 2 zhaozhanqi 2021-05-26 06:54:39 UTC

@nkononov

Could you help verified this bug?

Comment 6 errata-xmlrpc 2021-07-27 23:04:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438