Bug 1955668

Summary:	spectool -g refuses to download from FTP
Product:	[Fedora] Fedora	Reporter:	Jaroslav Škarvada <jskarvad>
Component:	rpmdevtools	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	33	CC:	bugs.michael, decathorpe, dennis, kevin, ngompa13, twoerner
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-30 16:15:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jaroslav Škarvada 2021-04-30 15:58:45 UTC

Description of problem:
It seems FTP transport stopped working.

Version-Release number of selected component (if applicable):
rpmdevtools-9.3-3.fc33.noarch

How reproducible:
Always

Steps to Reproduce:
1. spectool -g postfix.spec 
2. 
3.

Actual results:
Downloading: ftp://ftp.porcupine.org/mirrors/postfix-release/official/postfix-3.6.0.tar.gz
Download failed:
No connection adapters were found for 'ftp://ftp.porcupine.org/mirrors/postfix-release/official/postfix-3.6.0.tar.gz'

Expected results:
File downloaded

Additional info:
wget works as expected:
wget ftp://ftp.porcupine.org/mirrors/postfix-release/official/postfix-3.6.0.tar.gz
--2021-04-30 17:53:54--  ftp://ftp.porcupine.org/mirrors/postfix-release/official/postfix-3.6.0.tar.gz
           => „postfix-3.6.0.tar.gz“
...
downloaded

Comment 1 Fabio Valentini 2021-04-30 16:15:11 UTC

The python library that is used by spectool for streamed file downloads (requests) does not support FTP.
Adding support for FTP would require porting spectool to a different library (which I won't do) and adding another dependency (which RHEL maintainers do not want). Sorry.

PS: Does postfix only offer downloads via FTP? That seems wildly insecure, I would strongly recommend using HTTPS for downloads, if possible.