Bug 1955683

Summary: Windows MachineSet diskDiB change disk size but doesn't affect the partition size
Product: OpenShift Container Platform Reporter: Robert Bohne <rbohne>
Component: DocumentationAssignee: Michael Burke <mburke>
Status: CLOSED CURRENTRELEASE QA Contact: Xiaoli Tian <xtian>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.7CC: aos-bugs, mburke, sgao
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-11 15:59:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robert Bohne 2021-04-30 16:22:52 UTC 
Document URL: https://docs.openshift.com/container-platform/4.7/windows_containers/creating_windows_machinesets/creating-windows-machineset-vsphere.html#windows-machineset-vsphere_creating-windows-machineset-vsphere

Section Number and Name: Sample YAML for a Windows MachineSet object on vSphere

Describe the issue: 

diskGiB in the MachineSet change the size of the Disk/VMDK but NOT of the partition. It is helpful to mention this in the documentation. 

Suggestions for improvement: 

Add a note to the machineset that diskDiB change the size of the disk/VMD but not of the windows partition. 
It's possible to resize the partition via unattend.xml or create the golden image virtual machine with the appropriate disk size

Additional information: 
 * discussion in slack https://coreos.slack.com/archives/CM4ERHBJS/p1618997441371100
Comment 4 Michael Burke 2022-03-29 20:25:41 UTC 
Robert --

Can you please take a look at my PR to see if it meets your expectations? 

Thank you.

https://github.com/openshift/openshift-docs/pull/43943
Comment 5 Robert Bohne 2022-03-30 06:45:19 UTC 
Michael,  LGTM thank you!
Comment 6 Michael Burke 2022-03-30 14:02:20 UTC 
@sgaoshang You reviewed changes to this module previously. Is this an issue you can review? Thank you in advance.
Comment 7 Michael Burke 2022-04-11 15:59:40 UTC 
Changes are live: https://docs.openshift.com/container-platform/4.7/windows_containers/creating_windows_machinesets/creating-windows-machineset-vsphere.html#windows-machineset-vsphere_creating-windows-machineset-vsphere