Bug 1956304

Summary: KubevirtHyperconvergedClusterOperatorCRModification alert doesn't work as expected
Product: Container Native Virtualization (CNV) Reporter: Erkan Erol <eerol>
Component: InstallationAssignee: Erkan Erol <eerol>
Status: CLOSED ERRATA QA Contact: Satyajit Bulage <sbulage>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.8.0CC: cnv-qe-bugs, stirabos
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.8.0-350 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 14:31:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot is showing actual results. none

Description Erkan Erol 2021-05-03 12:47:07 UTC 
Description of problem:

KubevirtHyperconvergedClusterOperatorCRModification doesn't behave as expected.

It is not fired when the resource below are overwritten:
- configmap/kubevirt-storage-class-defaults
- configmap/v2v-vmware
- role/hco.kubevirt.io:config-reader
- rolebinding/hco.kubevirt.io:config-reader


Also, it is not fired when the counter is increased from zero to one. 


Version-Release number of selected component (if applicable): 4.8


How reproducible:


Steps to Reproduce:
1. Get a new 4.8 setup
2. Edit labels of configmap/v2v-vmware
3. Observe that the alert is not fired
4. Edit labels of kubevirt 
5. Observe that the alert is not fired
6. Edit labels of kubevirt  again
7. Observe that the alert is fired


Additionally, the alert have component_name label and it does only contain the name of operand. This makes troubleshooting harder since name of some operands don't have any clue about their type (e.g. networkaddonsconfigs/cluster) and there are some operands that have the same name but different types (role/hco.kubevirt.io:config-reader and rolebinding/hco.kubevirt.io:config-reader)
Comment 1 Erkan Erol 2021-05-03 12:50:14 UTC 
The PR below
- fixes the behavior for configmaps
- fixes the first change issue

https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1309/
Comment 2 Erkan Erol 2021-05-24 13:53:03 UTC 
Note that hco.kubevirt.io:config-reader role/rolebinding are still not strictly reconciled. We have another bug for those objects: https://bugzilla.redhat.com/show_bug.cgi?id=1963963#c0

We think those objects are not critical for the product and we can remove them from the scope of this bug.
Comment 3 Inbar Rose 2021-05-31 05:55:01 UTC 
missing fixed in version, please add.
Comment 4 Satyajit Bulage 2021-05-31 10:37:48 UTC 
After modifying below components:

- configmap/kubevirt-storage-class-defaults
- configmap/v2v-vmware

Able to see the Alert "KubevirtHyperconvergedClusterOperatorCRModification" is generated.
Comment 5 Satyajit Bulage 2021-05-31 10:40:14 UTC 
Created attachment 1788210 [details]
Screenshot is showing actual results.
Comment 8 errata-xmlrpc 2021-07-27 14:31:30 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.8.0 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2920