Bug 1956817

Summary:	due to change of logging in satellite 6.9 satellite installer logs are not properly obfuscated
Product:	Red Hat Enterprise Linux 7	Reporter:	Jan Jansky <jjansky>
Component:	sos	Assignee:	Jan Jansky <jjansky>
Status:	CLOSED ERRATA	QA Contact:	Maros Kopec <makopec>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.9	CC:	agk, bmr, cww, fkrska, jreznik, mhradile, plambri, pmoravec, sbradley, theute
Target Milestone:	rc	Keywords:	Triaged, ZStream
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	sos-3.9-5.el7_9.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-21 01:06:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Jansky 2021-05-04 13:28:31 UTC

Description of problem: due to change of logging in satellite 6.9 satellite installer logs are not properly obfuscated.

Foreman plugin needs to be updated with new regexp.


How reproducible: Always


Steps to Reproduce:
1. sosreport --build --batch -o foreman
2. grep foreman_proxy::puppetca_token_ttl <sos destination>/var/log/foreman-installer/satellite.log


Actual results:

2021-05-04 09:35:33 [DEBUG ] [configure] Found key: "foreman_proxy::puppetca_token_ttl" value: 360

Expected results:
2021-05-04 09:35:33 [DEBUG ] [configure]  Found key: "foreman_proxy::puppetca_token_ttl" value: ********

Additional info:
Tested myself on Satellite 6.9 and Satellite 6.7.

Comment 2 Pavel Moravec 2021-05-04 13:36:18 UTC

The token_ttl value isnt the critical information not being scrubbed. More relevant examples are e.g.:

2021-04-26 16:32:02 [DEBUG ] [configure] Found key: "foreman::db_password" value: "QDUerNfEdag4qQ8S5sw6VsTjpLY2wp9B"

2021-04-26 16:32:02 [DEBUG ] [configure] Found key: "foreman::oauth_consumer_secret" value: "ePFyZXLkbB3vCW45NjY6V6PF4xJP7hWv"

and similar.

Basically nothing with "Found key:" is obfuscated, neither few further regexp replacements are applied, since the foreman plugin raises an uncaught exception.

So the business justification is "this BZ prevents obfuscating majority of foreman secret stuff".

Comment 10 errata-xmlrpc 2021-07-21 01:06:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sos bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2804