Bug 1956964

setting priority to high because this issue comes up by many users

It related to storage issue: https://bugzilla.redhat.com/show_bug.cgi?id=1963027

set blocker to (-) because in regular flow users should set the target disk size to be bigger than the size of uploaded file.

set priority to high because the UI should have better handling of cases where users try to uploaded files bigger then the target filesystems.

Gilad hi,

can you comment here about the progress, with checking the file size ?
we also need to make sure that the error message a user see when the PVC size is too small is nicer than it is now

Kobig hi,

> When doing the same form Virtctl - the process is working well 

are you sure ?
can I upload a big image into a smaller PVC using the CLI ?
does it expand the PVC to match the size ?

> Please correct me if i wrong but the size of the PVC should be twice the size of the actual image disk right? this means if the image is 5G then the image is 10G, then way:
> 1. can we set the size automatically? when the user upload the file we just set the size X*2 and if he clicks next then it will work out of the box
> 2. why not adding this info to the wizard so the user will know what he needs to do and what size to give? I mean a regular Person will just give it what it needs or max, X*1.2 just to play safe, but no one will give x*2 of the size.

Gilad hi,

Can you implement Konbig suggestions in https://github.com/openshift/console/pull/9179 of some followup ?

yes, will implement x2 PVC size error message,
will also implement automatic size filling on choosing a file

There are two problems mentioned in this bug:
1. the error message is not nice
2. auto-fill the PVC size

For problem #1, let's take a look at the virtctl outputs, maybe we can give the same error message on UI like the virtctl did.

$ virtctl image-upload dv cirros2 --size=40Mi --image-path=./cirros.img --storage-class=ocs-storagecluster-ceph-rbd --access-mode=ReadWriteMany --block-volume --insecure
DataVolume gh/cirros2 created
Waiting for PVC cirros2 upload pod to be ready...
Pod now ready
Uploading data to https://cdi-uploadproxy-openshift-cnv.apps.akalenyu48.cnv-qe.rhcloud.com

 12.13 MiB / 12.13 MiB [==================================================================================================] 100.00% 14s

unexpected return value 400, Saving stream failed: Virtual image size 46137344 is larger than available size 41943040 (PVC size 46137344, reserved overhead 0.000000%). A larger PVC is required.



For problem #2, The image size is about 13M, but it requires PVC size is about 50M, not X*2, so I'm not sure how we can achieve the purpose by X*2.

$ virtctl image-upload dv cirros1 --size=50Mi --image-path=./cirros.img --storage-class=ocs-storagecluster-ceph-rbd --access-mode=ReadWriteMany --block-volume --insecure
DataVolume gh/cirros1 created
Waiting for PVC cirros1 upload pod to be ready...
Pod now ready
Uploading data to https://cdi-uploadproxy-openshift-cnv.apps.akalenyu48.cnv-qe.rhcloud.com

 12.13 MiB / 12.13 MiB [==================================================================================================] 100.00% 15s

Uploading data completed successfully, waiting for processing to complete, you can hit ctrl-c without interrupting the progress
Processing completed successfully
Uploading ./cirros.img completed successfully


And I tested that uploading a image via UI has no difference from virtctl image-upload.
On UI, uploading is failed if the pvc size is 40Mi, it succeeds if the PVC size is 50Mi.

(In reply to Guohua Ouyang from comment #9)
> There are two problems mentioned in this bug:
> 1. the error message is not nice
> 2. auto-fill the PVC size
> 
> For problem #1, let's take a look at the virtctl outputs, maybe we can give
> the same error message on UI like the virtctl did.
> 
> $ virtctl image-upload dv cirros2 --size=40Mi --image-path=./cirros.img
> --storage-class=ocs-storagecluster-ceph-rbd --access-mode=ReadWriteMany
> --block-volume --insecure
> DataVolume gh/cirros2 created
> Waiting for PVC cirros2 upload pod to be ready...
> Pod now ready
> Uploading data to
> https://cdi-uploadproxy-openshift-cnv.apps.akalenyu48.cnv-qe.rhcloud.com
> 
>  12.13 MiB / 12.13 MiB
> [============================================================================
> ======================] 100.00% 14s
> 
> unexpected return value 400, Saving stream failed: Virtual image size
> 46137344 is larger than available size 41943040 (PVC size 46137344, reserved
> overhead 0.000000%). A larger PVC is required.
> 
> 
> 
> For problem #2, The image size is about 13M, but it requires PVC size is
> about 50M, not X*2, so I'm not sure how we can achieve the purpose by X*2.
> 
> $ virtctl image-upload dv cirros1 --size=50Mi --image-path=./cirros.img
> --storage-class=ocs-storagecluster-ceph-rbd --access-mode=ReadWriteMany
> --block-volume --insecure
> DataVolume gh/cirros1 created
> Waiting for PVC cirros1 upload pod to be ready...
> Pod now ready
> Uploading data to
> https://cdi-uploadproxy-openshift-cnv.apps.akalenyu48.cnv-qe.rhcloud.com
> 
>  12.13 MiB / 12.13 MiB
> [============================================================================
> ======================] 100.00% 15s
> 
> Uploading data completed successfully, waiting for processing to complete,
> you can hit ctrl-c without interrupting the progress
> Processing completed successfully
> Uploading ./cirros.img completed successfully
> 
> 
> And I tested that uploading a image via UI has no difference from virtctl
> image-upload.
> On UI, uploading is failed if the pvc size is 40Mi, it succeeds if the PVC
> size is 50Mi.

The prefilled minimum size is 1Gi.
if the image size is above 0.5Gi, it will be x2 the image.

https://github.com/openshift/console/pull/9179 merged upstream, move to modified

Note to verifier:
a - user can not upload a file into a PVC that is smaller then the unzipped file.
b - the UI should alert users that the PVC may be smaller then needed to avoid such cases

The solution is still not good, now it has warning message "PVC size is smaller than double the provided image. Please ensure your PVC size covers the requirements of the uncompressed image and any other space requirements", as the tests above shows double size is not working.

I tested that filling a size which is larger than the double size of the image, the warning disappeard, but upload is still failed with 400 error.

Is there a way to show the similar error "unexpected return value 400, Saving stream failed: Virtual image size 46137344 is larger than available size 41943040 (PVC size 46137344, reserved overhead 0.000000%). A larger PVC is required." on UI? how hard will it be? I think it's best solution instead of estimating the possible size by ui.

I would assign the bug back because of upload is failed even it has no warning about the size.

verified on 4.10.0-0.nightly-2021-11-01-163833

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056