Bug 1957443

Summary: [OSP 17] sysfsutils is being removed in RHEL 9 so it should be removed from the nova containers.
Product: Red Hat OpenStack Reporter: smooney
Component: openstack-tripleo-commonAssignee: Bogdan Dobrelya <bdobreli>
Status: CLOSED ERRATA QA Contact: OSP DFG:Compute <osp-dfg-compute>
Severity: medium Docs Contact:
Priority: medium    
Version: 17.0 (Wallaby)CC: alifshit, bdobreli, dasmith, eglynn, jgrosso, jhakimra, jschluet, kchamart, lyarwood, mburns, sbauza, sethfisherh34642, sgordon, slinaber, vromanso
Target Milestone: gaKeywords: Triaged
Target Release: 17.1   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-tripleo-common-15.4.1-1.20230327141003.5fc8ba5.el9ost Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1957448 (view as bug list) Environment:
Last Closed: 2023-08-16 01:10:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1957448, 1960179    
Bug Blocks:    

Description smooney 2021-05-05 18:58:58 UTC
Description of problem:

sysfsutils was an optional depency of nova for fiber channel storage integration.
sysfsutils and systool shoudl nolonger be used in nova directly as a result this depency shoudl nolonger be required.

sysfsutils is going away in rhel 9 which will be the basis of osp 17 so we should remove it from the package list in the nova-compute container.

https://opendev.org/openstack/tripleo-common/src/branch/master/container-images/tcib/base/os/nova-base/nova-compute/nova-compute.yaml#L26

Version-Release number of selected component (if applicable):


How reproducible:
NA

Steps to Reproduce:
1.
2.
3.

Actual results:

sysfsutils is installed in the container

Expected results:

sysfsutils is not installed in the container.

Additional info:

Comment 1 Jon Schlueter 2021-05-05 20:09:16 UTC
direct usage of sysfsutils/systool was removed a while ago but it is still used by fiber channel in os-brick, but os-brick does require the package correctly.

Comment 5 Bogdan Dobrelya 2022-06-23 13:48:31 UTC
This is blocked on os-brick https://github.com/openstack/os-brick/blob/master/os_brick/initiator/linuxfc.py#L162
As noted by Lee:

So to be clear we should only go ahead with this removal once os-brick has been updated to drop this direct dependency on sysfsutils and the systool binary it provides. I'm going to also follow up and ensure this is reflected in both the openstack-nova and os-brick RPM spec files.

I would rise that to critical, as sysfsutils is being removed in RHEL 9, and that would block containers building pipeline until that os-brick sysfsutils dependency on resolved.

Putting it back to untriaged given the revised priority and changed scope for 17.0 to address criticals/blockers.

Comment 6 Jon Schlueter 2022-06-23 21:39:39 UTC
bug 1960179 is tracking getting usage removed from os-brick, from inspection python-os-brick.spec has the right Requires

Requires:       sysfsutils

So we should be able to drop it from tcib as an explicit entry for nova container image in tcib

Comment 7 Artom Lifshitz 2022-06-23 21:47:32 UTC
OK, so this BZ is just tracking removing sysfsutils from the Nova requirements? That's easy to do, but maybe let's not do it so close to 17.0 GA, to avoid the risk of blowing up CI. Since os-brick seems to require sysfsutils regardless, seems like we'll have to package it in layered products anyways.

Comment 8 Yaniv Kaul 2022-06-27 09:23:43 UTC
(In reply to Artom Lifshitz from comment #7)
> OK, so this BZ is just tracking removing sysfsutils from the Nova
> requirements? That's easy to do, but maybe let's not do it so close to 17.0
> GA, to avoid the risk of blowing up CI. Since os-brick seems to require
> sysfsutils regardless, seems like we'll have to package it in layered
> products anyways.

https://review.opendev.org/c/openstack/tripleo-common/+/790070/ was abandoned. What's the next step?

Comment 11 Jon Schlueter 2022-07-06 15:30:19 UTC
this can be defered to 17.1

Comment 14 Artom Lifshitz 2022-12-13 16:10:35 UTC
https://code.engineering.redhat.com/gerrit/c/python-os-brick/+/418621/ is in 17.0, so I think we're good to do our backport to wallaby and 17.x.

Comment 19 Seth 2023-06-22 11:32:30 UTC Comment hidden (spam)
Comment 20 Seth 2023-06-22 11:34:39 UTC Comment hidden (spam)
Comment 28 errata-xmlrpc 2023-08-16 01:10:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.1 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:4577

Comment 29 Diana Peters 2024-11-09 09:10:27 UTC Comment hidden (spam)
Comment 30 james598keen 2024-11-12 11:18:57 UTC Comment hidden (spam)
Comment 31 GracefulRestrictor 2024-11-27 09:58:44 UTC Comment hidden (spam)