Bug 1957485
| Summary: | GNOME 44 compatibility (gnome-shell-extension-openweather) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hin-Tak Leung <htl10> |
| Component: | gnome-shell-extension-openweather | Assignee: | Artem <ego.cordatus> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 38 | CC: | ego.cordatus, fedora, jan.public, ovirt, robatino |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | gnome-shell-extension-openweather-1-0.49.20210509gitd714eb1.fc35.noarch gnome-shell-extension-openweather-1-0.49.20210509gitd714eb1.fc35 gnome-shell-extension-openweather-1-0.51.20210509gitd714eb1.fc37 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-19 15:41:36 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Hin-Tak Leung
2021-05-05 20:35:28 UTC
FEDORA-2021-fe5888d393 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-fe5888d393 FEDORA-2021-fe5888d393 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. This bug now exists in F35 with GNOME 41. It works only if I disable extension version validation. FEDORA-2021-b5cd2f64a2 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b5cd2f64a2 @Andre thanks for reporting. Please try new update since i don't have time to test all of this. Thanks for update - works now in F35 without disabling extension version validation, karma given. FEDORA-2021-b5cd2f64a2 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. This bug now exists in F36 with GNOME 42. It works only if I disable extension version validation. FEDORA-2022-e4da74cea2 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e4da74cea2 FEDORA-2022-e4da74cea2 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-3fe1fc1845 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fe1fc1845 FEDORA-2022-3fe1fc1845 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-3fe1fc1845` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3fe1fc1845 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-3fe1fc1845 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. I can confirm that I can load the extension again and it is visible.
But I can't select any other location.
Than I receive the following:
Mai 09 07:35:07 fedora-testing-vm gjs[3735]: JS ERROR: TypeError: Soup.form_request_new_from_hash is not a function
loadJsonAsync@/usr/share/gnome-shell/extensions/openweather-extension/prefs.js:670:28
wrapper@resource:///org/gnome/gjs/modules/script/_legacy.js:83:27
initWindow/<@/usr/share/gnome-shell/extensions/openweather-extension/prefs.js:206:22
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:186:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:22:13
run@resource:///org/gnome/gjs/modules/script/package.js:206:19
start@resource:///org/gnome/gjs/modules/script/package.js:190:8
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17
This bug now exists in F38 with GNOME 44. It works only if I disable extension version validation. (There is also a separate issue where even if I disable version validation, I only see a circular arrow with 3 dots to the right, it never actually loads. Looking at https://gitlab.com/skrewball/openweather/-/issues to see if this is something I need to fix by editing user files or if the package itself needs fixing.) Figured it out, see https://gitlab.com/skrewball/openweather/-/issues/74 . Basically, I just edited extension.js to replace theme.set_custom_theme(St.Settings.get().gtk_icon_theme); with theme.set_custom_theme(St.Settings.get().gtk_icon_theme); to solve the not loading problem, and of course the GNOME 44 compatibility just requires editing metadata.json to replace "shell-version": ["42", "43"], with "shell-version": ["42", "43", "44"], and after logging out and back in it works without disabling version validation. You probably already know about this, just putting it here for any users looking. Won't bother to file a separate bug. Sorry, the replacement line in extension.js should have been theme.set_theme_name(St.Settings.get().gtk_icon_theme); |