Bug 1957591

Summary: [GUI] autocomplete attribute not set to "off" for password input field
Product: Red Hat Enterprise Linux 8 Reporter: Reid Wahl <nwahl>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: VERIFIED --- QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.3CC: cluster-maint, idevat, mlisik, mmazoure, mpospisi, nhostako, omular, slevine, tojeline
Target Milestone: rcKeywords: EasyFix, Security, Triaged
Target Release: 8.9   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pcs-0.10.16-1.el8 Doc Type: Bug Fix
Doc Text:
Instruct web browsers not to remember passwords entered into pcsd web UI login form. Note that web browsers may ignore this setting.
 Story Points: ---
Clone Of:
: 2174711 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Reid Wahl 2021-05-06 05:48:28 UTC 
Description of problem:

The following text is from the reporting user:
~~~
Vulnerability Scanner has identified Vulnerability titled:AutoComplete Attribute Not Disabled for Password in Form Based Authentication in Pacemaker PCSD. Detected on 2224 port which is pcsd port.

As per scanner recommendation "Contact the vendor to have the AutoComplete attribute disabled for the password field in all forms. The AutoComplete attribute should also be disabled for the user ID field.  

Developers can add the following attribute to the form or input element: autocomplete="off"

This attribute prevents the browser from prompting the user to save the populated form values for later reuse.

Most browsers no longer honor autocomplete="off" for password input fields. These browsers include Chrome, Firefox, Microsoft Edge, IE, Opera

However, there is still an ability to turn off autocomplete through the browser and that is recommended for a shared computing environment.

"Since the ability to turn autocomplete off for password inputs fields is controlled by the user it is highly recommended for application to enforce strong password rules.
~~~

More detail about the attribute here:
  - https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

The practical risk that's present here seems very low. Nonetheless, this seems like a straightforward change if we decide to make it.

The reporter opened a case against RHEL 7.9. I'm opening this BZ against RHEL 8. We can clone if desired.

-----

Version-Release number of selected component (if applicable):

pcs-0.10.6-4.el8

-----

How reproducible:

Always

-----

Steps to Reproduce:

Trivial; check for autocomplete attribute on the password input of the authentication form in the pcsd web UI.

-----

Actual results:

`autocomplete="off"` attribute not present.

-----

Expected results:

`autocomplete="off"` attribute present.
Comment 1 Reid Wahl 2021-05-06 05:50:41 UTC 
The reporter stated that there is no CVE associated with this vulnerability scan result.
Comment 2 Huzaifa S. Sidhpurwala 2021-05-24 04:28:24 UTC 
Really looks like security hardening to me, and that too borderline. So this is not a security flaw, hence no CVE
Comment 3 Tomas Jelinek 2023-03-02 09:31:56 UTC 
Upstream patch:
https://github.com/ClusterLabs/pcs/commit/65571b8f455ac9133c7271ee6deefd484cb5dabe

Test / reproducer in comment 0.
Comment 8 Michal Pospisil 2023-05-29 10:09:41 UTC 
DevTestResults:

<tr>
  <td style="text-align:right;">Password:</td>
  <td><input type="password" name="password" autocomplete="off"></td>
</tr>

The password field contains the autocomplete attribute.