Bug 1957795

Summary:	Review Request: perl-Syntax-Keyword-Defer - Add defer block syntax to Perl
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Syntax-Keyword-Defer-0.05-1.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-17 15:43:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2021-05-06 13:45:51 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Defer/perl-Syntax-Keyword-Defer.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-Defer/perl-Syntax-Keyword-Defer-0.05-1.fc35.src.rpm
Description:
This Perl module provides a syntax plugin that implements a block which
executes when the containing scope has finished. The "defer" blocks are
primarily intended for cases such as resource finalization tasks that may be
conditionally required.

Fedora Account System Username: ppisar

Comment 1 Petr Pisar 2021-05-06 13:55:54 UTC

*** Bug 1957800 has been marked as a duplicate of this bug. ***

Comment 2 Robert-André Mauchin 🐧 2021-05-15 16:41:34 UTC

Source0 archive (SHA-512: 1a9a549467e5129afbadc4cb80b38afbcc37e9a7975c29fd5dc5a63105a958a1825665d8460b274dac76a56043ba22b5977efd9d8209413f72fb8700b1afb854) is original. Ok.
Summary verified from lib/Syntax/Keyword/Defer.pm. Ok.
Description verified from lib/Syntax/Keyword/Defer.pm. Ok.
License verified from LICENSE, Build.PL, and lib/Syntax/Keyword/Defer.pm Ok.
XS code, Arch is Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Syntax-Keyword-Defer.spec review-perl-Syntax-Keyword-Defer/results/perl-Syntax-Keyword-Defer-0.05-1.fc35.src.rpm review-perl-Syntax-Keyword-Defer/results/perl-Syntax-Keyword-Defer-0.05-1.fc35.x86_64.rpm 
perl-Syntax-Keyword-Defer.x86_64: W: library-not-linked-against-libc /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Defer/Defer.so
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpm -q -lv -p review-perl-Syntax-Keyword-Defer/results/perl-Syntax-Keyword-Defer-0.05-1.fc35.x86_64.rpm
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib/.build-id
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib/.build-id/d3
lrwxrwxrwx    1 root     root                       74 May 15 18:23 /usr/lib/.build-id/d3/88bdd335456fd69aff1626b6076870c38d453e -> ../../../../usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Defer/Defer.so
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib64/perl5/vendor_perl/Syntax
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib64/perl5/vendor_perl/Syntax/Keyword
-rw-r--r--    1 root     root                     6299 May 15 18:23 /usr/lib64/perl5/vendor_perl/Syntax/Keyword/Defer.pm
-rw-r--r--    1 root     root                     1538 May 15 18:23 /usr/lib64/perl5/vendor_perl/Syntax/Keyword/Finally.pm
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib64/perl5/vendor_perl/auto/Syntax
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Defer
-rwxr-xr-x    1 root     root                    15280 May 15 18:23 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Defer/Defer.so
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/share/doc/perl-Syntax-Keyword-Defer
-rw-r--r--    1 root     root                     1390 Apr 22 00:17 /usr/share/doc/perl-Syntax-Keyword-Defer/Changes
-rw-r--r--    1 root     root                     5792 Apr 22 00:17 /usr/share/doc/perl-Syntax-Keyword-Defer/README
drwxr-xr-x    2 root     root                        0 May 15 18:23 /usr/share/licenses/perl-Syntax-Keyword-Defer
-rw-r--r--    1 root     root                    18418 Apr 22 00:17 /usr/share/licenses/perl-Syntax-Keyword-Defer/LICENSE
-rw-r--r--    1 root     root                     4182 May 15 18:23 /usr/share/man/man3/Syntax::Keyword::Defer.3pm.gz
-rw-r--r--    1 root     root                     2332 May 15 18:23 /usr/share/man/man3/Syntax::Keyword::Finally.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p review-perl-Syntax-Keyword-Defer/results/perl-Syntax-Keyword-Defer-0.05-1.fc35.x86_64.rpm | sort -f | uniq -c
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(:VERSION) >= 5.14.0
      1 perl(Carp)
      1 perl(warnings)
      1 perl(XS::Parse::Keyword)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
      1 rtld(GNU_HASH)
Binary Requires are Ok.

$ rpm -q --provides -p review-perl-Syntax-Keyword-Defer/results/perl-Syntax-Keyword-Defer-0.05-1.fc35.x86_64.rpm | sort -f | uniq -c

      1 perl(Syntax::Keyword::Defer) = 0.05
      1 perl(Syntax::Keyword::Finally) = 0.05
      1 perl-Syntax-Keyword-Defer = 0.05-1.fc35
      1 perl-Syntax-Keyword-Defer(x86-64) = 0.05-1.fc35
Binary Provides are Ok.

The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=67980951). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 3 Petr Pisar 2021-05-17 09:21:15 UTC

https://pagure.io/releng/fedora-scm-requests/issue/34067

Comment 4 Gwyn Ciesla 2021-05-17 13:38:42 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-Defer

Comment 5 Petr Pisar 2021-05-17 15:39:00 UTC

Thank you for the review and the repository.

Comment 6 Petr Pisar 2021-05-17 15:43:02 UTC

Gating passed.