Bug 1958080

Summary: Missing i18n for login, error and selectprovider pages
Product: OpenShift Container Platform Reporter: Jakub Hadvig <jhadvig>
Component: Management ConsoleAssignee: Yadan Pei <yapei>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.8CC: aos-bugs, jokerman, yapei
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 23:07:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
login page is loaded in English when browser language is set to Chinese
none
selectprovider page translated
none
login page translated
none
authentication error not translated
none
authentication error is translated - chinese none

Description Jakub Hadvig 2021-05-07 06:55:29 UTC 
Description of problem:
When logging into openshift console, we have three pages that are maintained by the oauth-server:
- login page
- error page
- selectprovider page
For all three we are missing internationalisation, based on the 'Accept-Language' request header.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
All three pages are hardcoded in English

Expected results:
Based on the language in the 'Accept-Language' request header, preferred language should be set (en, zh, ko, ja) 


Additional info:
Comment 2 Yadan Pei 2021-05-08 10:01:33 UTC 
1. Set browser language as Chinese then visit OCP console, I can see the Accept-Language in GET /login request is set to following

Accept-Language: zh-CN,en-US;q=0.8,en;q=0.5,ja;q=0.3


but the login page is still loaded in English(see screenshot)

Jakub, could you help confirm?
Comment 3 Yadan Pei 2021-05-08 10:02:09 UTC 
Created attachment 1780987 [details]
login page is loaded in English when browser language is set to Chinese
Comment 4 Yadan Pei 2021-05-08 10:08:20 UTC 
I got results in comment 2, comment 3 on a cluster at version 4.8.0-0.nightly-2021-05-08-025039 which should already include the fix 

the fix PR was merged in https://amd64.ocp.releases.ci.openshift.org/releasestream/4.8.0-0.nightly/release/4.8.0-0.nightly-2021-05-07-120058
Comment 5 Yadan Pei 2021-05-10 01:56:07 UTC 
Seems the login error information is still not translated, is there any PR has the feature? Moving back to get double confirm
Comment 6 Yadan Pei 2021-05-10 01:57:06 UTC 
Created attachment 1781469 [details]
selectprovider page translated
Comment 7 Yadan Pei 2021-05-10 01:58:35 UTC 
Created attachment 1781470 [details]
login page translated
Comment 8 Yadan Pei 2021-05-10 01:59:11 UTC 
Created attachment 1781471 [details]
authentication error not translated
Comment 10 Yadan Pei 2021-05-31 06:16:56 UTC 
Created attachment 1788146 [details]
authentication error is translated - chinese

Confirmed that now when browser language is set to Chinese, Japanese, Korean, these pages are translated correspondingly

1. login provider selection
2. login
3. login error 


Verified on 4.8.0-0.nightly-2021-05-29-114625
Comment 11 Yadan Pei 2021-05-31 06:18:04 UTC 
Remove NEEDINFO since the problem is resolved
Comment 14 errata-xmlrpc 2021-07-27 23:07:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438