Bug 1958382

Summary: Spam warnings about iterator.hpp being deprecated
Product: [Fedora] Fedora Reporter: Ben Webb <ben>
Component: boostAssignee: Thomas Rodgers <trodgers>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 34CC: dakingun, denis.arnaud_fedora, jwakely, trodgers
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: boost-1.78.0-0.fc37 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-08 06:28:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ben Webb 2021-05-07 19:02:33 UTC
Description of problem:
Trying to compile a single program using Boost now spams the output with lots of warnings about iterator.hpp (which we don't use) being deprecated. We get thousands of such messages when building our software, which makes it very hard to spot genuine issues.

Version-Release number of selected component (if applicable):
boost-1.75.0-4.fc34.x86_64

How reproducible:
Always

Steps to Reproduce:
1. cat test.cpp 
#include <boost/graph/adjacency_list.hpp>
int main() { return 0; }

2. g++ -Wall test.cpp

Actual results:
In file included from /usr/include/boost/smart_ptr/detail/sp_thread_sleep.hpp:2,
                 from /usr/include/boost/smart_ptr/detail/yield_k.hpp:23,
                 from /usr/include/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14,
                 from /usr/include/boost/smart_ptr/detail/spinlock.hpp:42,
                 from /usr/include/boost/smart_ptr/detail/spinlock_pool.hpp:25,
                 from /usr/include/boost/smart_ptr/shared_ptr.hpp:29,
                 from /usr/include/boost/property_map/vector_property_map.hpp:1,
                 from /usr/include/boost/property_map/property_map.hpp:602,
                 from /usr/include/boost/graph/adjacency_list.hpp:27,
                 from test.cpp:1:
/usr/include/boost/detail/iterator.hpp:13:1: note: ‘#pragma message: This header is deprecated. Use <iterator> instead.’
   13 | BOOST_HEADER_DEPRECATED("<iterator>")
      | ^~~~~~~~~~~~~~~~~~~~~~~


Expected results:
Compiles without warnings (as was the case in F33).


Additional info:
Note that not only do we not include iterator.hpp directly, none of the headers mentioned in the warning include it either (looks like this is pointing to the definition of the BOOST_PRAGMA_MESSAGE macro, which is not helpful, not where it's used). g++ -E reveals the correct chain of #includes, i.e.
/usr/include/boost/graph/adjacency_list.hpp -> /usr/include/boost/graph/detail/adjacency_list.hpp -> /usr/include/boost/graph/adjacency_iterator.hpp -> /usr/include/boost/detail/iterator.hpp

See also https://github.com/boostorg/property_map/pull/15 which looks like it should resolve this.

Comment 1 Jonathan Wakely 2021-05-07 20:25:32 UTC
(In reply to Ben Webb from comment #0)
> See also https://github.com/boostorg/property_map/pull/15 which looks like
> it should resolve this.

No, it's https://github.com/boostorg/graph/pull/218

Comment 2 Thomas Rodgers 2021-05-07 20:36:58 UTC
On the plus side, we try to give you fresh Boost in Fedora. On the not so plus side, you sometimes trip over Boost's release process... 

See -
https://github.com/boostorg/graph/pull/218

Fixed in this commit -
https://github.com/boostorg/graph/commit/f364ee7be2bb1a44a2724d92f67490deaf19dc5e

Comment 3 Ben Cotton 2022-05-12 16:55:43 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 4 Ben Cotton 2022-06-08 06:28:43 UTC
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 5 Jonathan Wakely 2022-06-09 11:39:30 UTC
Fixed in rawhide by the update to Boost 1.78.0