Bug 1958649

Summary: Mapping information disappears from "Plan summary" page if the plan is edited
Product: Migration Toolkit for Virtualization Reporter: Igor Braginsky <ibragins>
Component: User ExperienceAssignee: Mike Turley <mturley>
Status: CLOSED ERRATA QA Contact: Igor Braginsky <ibragins>
Severity: high Docs Contact: Avital Pinnick <apinnick>
Priority: high    
Version: 2.0.0CC: apinnick, fdupont, gdubreui, istein, mguetta, mturley
Target Milestone: ---Keywords: Regression
Target Release: 2.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-10 17:12:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Storage and network mapping fields are empty none

Description Igor Braginsky 2021-05-09 14:55:16 UTC
Created attachment 1781295 [details]
Storage and network mapping fields are empty

Description of problem: Plan wizard summary page doesn't reflect ANY mapping info when editing existing plan


Version-Release number of selected component (if applicable): 2.0.0-12


How reproducible: 100%


Steps to Reproduce:
1. Create a new provider, network and storage mappings and plan that will use all that
2. Edit just created plan
3. Go to summary page

Actual results: Storage and network mapping fields will be empty


Expected results: Mapping fields should be populated


Additional info:

Comment 1 Fabien Dupont 2021-05-10 08:05:49 UTC
I think this BZ is related to https://bugzilla.redhat.com/show_bug.cgi?id=1958652.
My understanding is that the wizard doesn't load the data from the mapping linked to the plan which has (at least) two side effects:

1. The default is again pre-selected when going through all the steps.
2. The review is empty.

@mturley @gdubreui can you check and tell me if I'm correct?

Comment 2 Mike Turley 2021-05-10 09:22:27 UTC
That's definitely a regression, we load the data from the linked mapping and it had been working fine recently.

Igor, can you share the cluster where you're seeing this?

Comment 3 Igor Braginsky 2021-05-10 09:30:57 UTC
This is mgn03 on PSI. Do you need connection details or is this enough for you?

Comment 4 Mike Turley 2021-05-10 16:51:20 UTC
Should be fixed by https://github.com/konveyor/forklift-ui/pull/591 (backport: https://github.com/konveyor/forklift-ui/pull/592).

See notes in the PR.. I'm not certain this will fix the issue for network mappings, only storage mappings. I was not able to reproduce the issue for network mappings. @ibragins if you can help me reproduce that, either now or when verifying this fix, that would be great.

I suspect the network mapping part of the issue may have been caused by either source or target networks being changed/removed in the providers after the plan was created and before it was edited. Opened https://github.com/konveyor/forklift-ui/issues/590 to handle that, but if that's the case I don't think it should be a release blocker.

Comment 5 Mike Turley 2021-05-10 19:25:41 UTC
Reproduced and figure out the issue with the network mappings here, it was related to cache invalidation. Also fixed in the above PR.

Comment 6 Fabien Dupont 2021-05-11 06:29:33 UTC
The fix is in build 2.0.0-13 / iib:74067.

Comment 7 Igor Braginsky 2021-05-11 09:03:36 UTC
Verified this on MTV 2.0.0-13, mapping info is on its place and it is correct

Comment 10 errata-xmlrpc 2021-06-10 17:12:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381