Bug 1958652

Summary:	Default storage is used instead of the storage selected in the Migration Plan wizard
Product:	Migration Toolkit for Virtualization	Reporter:	Igor Braginsky <ibragins>
Component:	User Experience	Assignee:	Mike Turley <mturley>
Status:	CLOSED ERRATA	QA Contact:	Igor Braginsky <ibragins>
Severity:	high	Docs Contact:	Avital Pinnick <apinnick>
Priority:	high
Version:	2.0.0	CC:	apinnick, fdupont, istein, mguetta
Target Milestone:	---	Keywords:	Regression
Target Release:	2.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-10 17:12:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Igor Braginsky 2021-05-09 15:02:48 UTC

Description of problem: Only default storage is taken instead of selected when creating plan in UI


Version-Release number of selected component (if applicable): 2.0.0-12


How reproducible: 100%


Steps to Reproduce:
1. Create new plan and configure it to use not-default storage (ceph-rbd in my case)
2. Edit plan and go to storage mappings section
3. See which storage will be selected

Actual results: Default storage type will be selected instead of one selected by user


Expected results:


Additional info:

Comment 1 Fabien Dupont 2021-05-10 07:34:15 UTC

What happens if you cancel the plan edit and run it? Will it use the selected storage class or the default one? If it uses the selected one, I don't think it's urgent.

I'm asking, because I'm suspecting that the UI reuses the same logic as during the plan creation and pre-selects the default storage class.
If that's the case, it's a confusing behavior and should be fixed, but it can wait until 2.1.0.

Comment 2 Igor Braginsky 2021-05-10 08:25:18 UTC

@fdupont you are right, if I just create plan and run it - proper storage type is used for it, problem is relevant only when I'm editing plan.

Comment 3 Fabien Dupont 2021-05-10 08:44:15 UTC

Thanks. Then, I really think that this BZ and https://bugzilla.redhat.com/show_bug.cgi?id=1958649 should be fixed together.

Comment 4 Mike Turley 2021-05-10 14:29:09 UTC

Investigating further, I think the two BZs are caused by separate issues, but the fixes would conflict so I will fix them together.

Comment 5 Mike Turley 2021-05-10 15:46:58 UTC

Ha! Fabien, you were right, these were the same issue. I misunderstood what was happening with prefilling mappings (the code I thought was broken is fine), and after going back to square one I found that both BZs come down to one dumb typo. PR incoming.

Comment 6 Mike Turley 2021-05-10 16:51:35 UTC

Should be fixed by https://github.com/konveyor/forklift-ui/pull/591 (backport: https://github.com/konveyor/forklift-ui/pull/592).

Comment 7 Fabien Dupont 2021-05-11 06:29:40 UTC

The fix is in build 2.0.0-13 / iib:74067.

Comment 8 Igor Braginsky 2021-05-11 09:06:15 UTC

Verified this on MTV 2.0.0-13, storage type selected by user during creation is there when editing plan.

Comment 11 errata-xmlrpc 2021-06-10 17:12:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381