Bug 195867

*** Bug 195868 has been marked as a duplicate of this bug. ***

Review for this package:-
    Mock Build Results for i386 
       -Successfully built on i386
MUST Items:
     - MUST: rpmlint shows error 
        W: tetex-IEEEtran invalid-license Perl Artistic License
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package IEEEtran.zip, is not
in the format IEEEtran.spec
      You CAN change upstream package name to tetex-IEEEtran.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is NOT licensed with any open-source compatible license.
      - MUST: The License field in the package tetex-IEEEtran.spec file is NOT
included in upstream tarball.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
      - MUST: This package owns all directories that it creates. 
      - MUST: This package did not contain any duplicate files in the %files
listing.
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.

Builds fine in mock (x86_64, development). rpmlint errors as above; you just
need to change your license tag to "Artistic".

You should supply the full URL to the source if you can (so folks can just run
spectool -g to download the upstream sources for your package).  You have the
URL in there but commented out so perhaps there's something I'm not understanding.

Regarding lyx, what needs to be generated?  Does lyx generate what it needs when
it installs?  If so, then you can just do the necessary setup conditionally
based on whether you find lyx there or not.  Otherwise you need to use triggers
or get the lyx packagers to set something up for you.  It's probably best to
talk to them anyway.

Review:
* package meets naming and packaging guidelines (we have no specific guidelines
for tetex-subpackages)
X specfile is properly named, is cleanly written and uses macros consistently
(see source URL issue above)
* dist tag is present.
* build root is correct.
O license field matches the actual license (use "Artistic" to appease rpmlint)
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (x86_64, development).
X rpmlint complains about license tag
* final provides and requires are sane:
   tetex-IEEEtran = 1.6c-1.fc6
  =
   /bin/sh
   /usr/bin/texhash
   tetex-latex
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* scriptlets present and OK (texhash calls)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Thanks for the feedback. Here's rev 2...

Spec URL: http://miskatonic.dyn-o-saur.com/pub/tetex-IEEEtran.spec
SRPM URL: http://miskatonic.dyn-o-saur.com/pub/fedora/5/srpms/tetex-IEEEtran-
1.6c-1.src.rpm

And the changelog...
- Changed License tag from Perl Artistic License to Artistic
- Added IEEEtrantools to package
- Put full URL into source

As for the URL, the commented out URL was in tetex-bytefield so I left it like 
that for now. It seems to work fine uncommented though. Maybe tetex-bytefield 
needs and update????

As for lyx, I'm not sure if it's possible to update without user intervention, 
but I'll contact the lyx maintainers anyway. But, for now this should be a 
complete tetex package.

It looks like the URL broke across two lines.

SRPM URL: http://miskatonic.dyn-o-saur.com/pub/fedora/5/srpms/tetex-IEEEtran-
1.6c-1.src.rpm

All that, and I didn't even update the SRPM link... one last try to correct the 
revision. I'm pretty sure you'll have to copy and paste the URL in pieces 
rather than using the link.

SRPM URL: http://miskatonic.dyn-o-saur.com/pub/fedora/5/srpms/tetex-IEEEtran-
1.6c-2.src.rpm

The issues I had are fixed; everything looks good.

APPROVED