Bug 1958993

Summary:	Leapp can print a confusing warning when the NetworkManager has been completely removed
Product:	Red Hat Enterprise Linux 7	Reporter:	Christophe Besson <cbesson>
Component:	leapp-repository	Assignee:	Leapp Notifications Bot <leapp-notifications-bot>
Status:	NEW ---	QA Contact:	upgrades-and-conversions
Severity:	low	Docs Contact:
Priority:	low
Version:	7.9	CC:	fkrska
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1818088

Description Christophe Besson 2021-05-10 14:37:04 UTC

Description of problem:
During the leapp_resume.service, at the very end of the upgrade, customer reported a confusing warning:

May  6 15:50:54 <HOSTNAME> leapp3[1735]: 2021-05-06 15:50:54.29  WARNING  PID: 2126 leapp.workflow.FirstBoot.network_manager_update_connections: Error calling nm-update-client-ids script: Command ['/usr/bin/python3', 'tools/nm-update-client-ids.py'] failed with exit code 1.

As per the sosreport, the NetworkManager has been completely removed from that system, and ifcfg files contain the directive NM_CONTROLLED=no. All was going well, but this warning should not be shown in this case, since that python script tries to connect to the NM daemon.

Version-Release number of selected component (if applicable):
leapp-repository-0.13.0-2.el7_9

How reproducible:
100% for the customer. Not tested internally.