Bug 1958995
| Summary: | python-pynetdicom fails to build with Python 3.10: ssl.SSLError: [SSL] called a function you should not call (_ssl.c:981) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | python-pynetdicom | Assignee: | Alessio <alciregi> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | alciregi, cheimes, mhroncok, neuro-sig, sanjay.ankur, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-pynetdicom-1.5.7-3.fc35 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-07-06 20:18:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1890881, 1927309, 1927313 | ||
"[SSL] called a function you should not call" typically means that the package is using a server-side context for a client-side connection or the other way around. The ssl module in Python 3.10 is more strict. https://github.com/pydicom/pynetdicom/blob/93b4a09831dc0bd7b6892996942a06755740ca82/pynetdicom/tests/test_transport.py#L300 """Return a good client SSLContext.""" context = ssl.create_default_context( ssl.Purpose.CLIENT_AUTH, cafile=SERVER_CERT) A client context must use SERVER_AUTH. This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.
The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.
You can either build the package in the side tag, with:
$ fedpkg build --target=f35-python
Or you can the build and we will eventually build it for you.
Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.
Thanks.
See also https://fedoraproject.org/wiki/Changes/Python3.10
If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build. *** Bug 1969094 has been marked as a duplicate of this bug. *** Hello, This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs). If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem. temporarily disabled the TLS tests for the time being Alessio. |
python-pynetdicom fails to build with Python 3.10.0b1: =================================== FAILURES =================================== ____________________ TestTLS.test_tls_yes_server_yes_client ____________________ self = <pynetdicom.tests.test_transport.TestTLS object at 0x7f09cdbbbfa0> server_context = <ssl.SSLContext object at 0x7f09b7ceb9c0> client_context = <ssl.SSLContext object at 0x7f09b7cea5c0> def test_tls_yes_server_yes_client(self, server_context, client_context): """Test associating with TLS on both ends.""" self.ae = ae = AE() ae.acse_timeout = 5 ae.dimse_timeout = 5 ae.network_timeout = 5 ae.add_supported_context('1.2.840.10008.1.1') server = ae.start_server( ('', 11112), block=False, ssl_context=server_context, ) ae.add_requested_context('1.2.840.10008.1.1') assoc = ae.associate('', 11112, tls_args=(client_context, None)) > assert assoc.is_established E assert False E + where False = <Association(RequestorThread@20210510130818, initial daemon)>.is_established pynetdicom/tests/test_transport.py:319: AssertionError ----------------------------- Captured stderr call ----------------------------- I: Requesting Association E: Association request failed: unable to connect to remote E: TCP Initialisation Error: Connection refused E: [SSL] called a function you should not call (_ssl.c:981) Traceback (most recent call last): File "/builddir/build/BUILD/pynetdicom-1.5.7/pynetdicom/transport.py", line 151, in connect self.socket.connect(address) File "/usr/lib64/python3.10/ssl.py", line 1372, in connect self._real_connect(addr, False) File "/usr/lib64/python3.10/ssl.py", line 1363, in _real_connect self.do_handshake() File "/usr/lib64/python3.10/ssl.py", line 1339, in do_handshake self._sslobj.do_handshake() ssl.SSLError: [SSL] called a function you should not call (_ssl.c:981) E: Association Aborted For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02175070-python-pynetdicom/ For all our attempts to build python-pynetdicom with Python 3.10, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-pynetdicom/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/ Let us know here if you have any questions. Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.