Bug 1959022

Summary:	libdnf advisory APIs for context do not expose update suggestion (reboot, relogin)
Product:	[Fedora] Fedora	Reporter:	Neal Gompa <ngompa13>
Component:	libdnf	Assignee:	rpm-software-management
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	35	CC:	amatej, dmach, jmracek, jrohel, mblaha, pkratoch, rpm-software-management
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-30 08:57:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1665453

Description Neal Gompa 2021-05-10 15:12:56 UTC

Description of problem:
libdnf's advisory API for the context API lacks a method that returns the suggestion for whether an update advisory suggests a reboot or relogin. This makes it impossible for PackageKit to give software centers the option to be smarter about triggering offline updates.

Version-Release number of selected component (if applicable):
0.62.0-1.fc34

Additional info:
See the linked KDE bug for details.

Comment 1 Neal Gompa 2021-05-10 16:21:03 UTC

It seems that reboot_suggested and relogin_suggested flags are per-package. Does that mean we need to extend the DnfAdvisoryPkg object to contain that data?

Comment 2 Ben Cotton 2021-08-10 13:01:53 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 3 Ben Cotton 2022-11-29 16:56:47 UTC

This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 4 amatej 2022-11-30 08:57:33 UTC

(In reply to Neal Gompa from comment #1)
> It seems that reboot_suggested and relogin_suggested flags are per-package.
> Does that mean we need to extend the DnfAdvisoryPkg object to contain that
> data?

Yes, dnf5 already has AdvisoryPackage with: get_reboot_suggested(), get_restart_suggested(), get_relogin_suggested() API.
While still in development dnf5 is available in rawhide.