Bug 1959223

Summary: CNO: invalid Netflow port causes ovnkube pods CrashLoopBackOff
Product: OpenShift Container Platform Reporter: Ross Brattain <rbrattai>
Component: NetworkingAssignee: Ben Pickard <bpickard>
Networking sub component: ovn-kubernetes QA Contact: Anurag saxena <anusaxen>
Status: CLOSED DUPLICATE Docs Contact:
Severity: medium    
Priority: unspecified CC: aconstan
Version: 4.8   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-20 20:15:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ross Brattain 2021-05-11 02:57:24 UTC
Description of problem:

CNO doesn't validate Port argument for exportNetworkFlows.  In this case a parseInt overflow.


Version-Release number of selected component (if applicable):

4.8.0-0.nightly-2021-05-08-132247

How reproducible:

always


Steps to Reproduce:
1. oc apply the following YAML

apiVersion: operator.openshift.io/v1
kind: Network
metadata:
  name: cluster
spec:
  exportNetworkFlows:
    netFlow:
      collectors:
        - 10.131.0.9:20561244234


Actual results:

We fail in ovnkube strconv.ParseInt due to overflow.   The openAPIV3Schema doesn't reject this because we don't limit the length of the port string in the regex  `:[0-9]+$`

F0511 02:31:18.414329  312944 ovnkube.go:130] netflow targets invalid: collector port 20561244234 is not a valid port: strconv.ParseInt: parsing "20561244234": value out of range



Expected results:

Invalid inputs are rejected, ideally no CrashLoopBackoffs.


Additional info:

Comment 1 Ben Pickard 2021-05-20 20:15:23 UTC

*** This bug has been marked as a duplicate of bug 1960101 ***