Bug 1960375

Summary:	the postfix role is not idempotent
Product:	Red Hat Enterprise Linux 8	Reporter:	Rich Megginson <rmeggins>
Component:	rhel-system-roles	Assignee:	Rich Megginson <rmeggins>
Status:	CLOSED ERRATA	QA Contact:	David Jež <djez>
Severity:	unspecified	Docs Contact:	Eliane Ramos Pereira <elpereir>
Priority:	unspecified
Version:	8.5	CC:	djez, elpereir, nhosoi, spetrosi
Target Milestone:	beta	Keywords:	Triaged
Target Release:	8.5	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	role:postfix
Fixed In Version:	rhel-system-roles-1.4.0-1.el8	Doc Type:	Bug Fix
Doc Text:	.Role tasks no longer change when running the same output Previously, several of the role tasks would report as `CHANGED` when running the same input once again, even if there were no changes. Consequently, the role was not acting idempotent. To fix the issue, perform the following actions: * Check if configuration variables change before applying them. You can use the option `--check` for this verification. * Do not add a `Last Modified: $date` header to the configuration file. As a result, the role tasks are idempotent.	Story Points:	---
Clone Of:
Clones:	1978760 (view as bug list)		Environment:
Last Closed:	2021-11-09 17:45:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1957876
Bug Blocks:	1978760

Description Rich Megginson 2021-05-13 18:07:03 UTC

Description of problem:
The postfix role is not idempotent.  If you run the role one day, then run the role another day, the config file is updated in the step "Add header 1 to configuration file" which adds the "# Last Modified: $date" to the config file, because it uses the date.

It is bad practice to use a "# Last Modified: $date" header for this reason.  The role should omit this header.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 15 errata-xmlrpc 2021-11-09 17:45:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4159