Bug 1961166
| Summary: | Review Request: perl-Test2-Tools-Process - Unit tests for code that calls exit, exec, system or qx() | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test2-Tools-Process-0.05-1.fc35 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-19 06:26:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1960969 | ||
|
Description
Petr Pisar
2021-05-17 11:54:29 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
$ rpm -qp --requires perl-Test2-Tools-Process-0.05-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
1 perl(base)
1 perl(Capture::Tiny)
1 perl(Carp)
1 perl(Class::Tiny)
1 perl(constant)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.32.1)
1 perl(Ref::Util)
1 perl(Scope::Upper)
1 perl(strict)
1 perl(Test2::API) >= 1.302015
1 perl(Test2::Compare) >= 0.000060
1 perl(Test2::Compare::Array) >= 0.000060
1 perl(Test2::Compare::Custom) >= 0.000060
1 perl(Test2::Compare::Number) >= 0.000060
1 perl(Test2::Compare::String) >= 0.000060
1 perl(Test2::Compare::Wildcard) >= 0.000060
1 perl(Test2::Tools::Compare) >= 0.000060
1 perl(Test2::Tools::Process)
1 perl(Test2::Tools::Process::ReturnMultiLevel)
1 perl(:VERSION) >= 5.10.0
1 perl(warnings)
Binary requires are almost Ok.
FIX: Add missing run-requires
- perl(Config) - lib/Test2/Tools/Process.pm:202
$ rpm -qp --provides perl-Test2-Tools-Process-0.05-1.fc35.noarch.rpm | sort | uniq -c
1 perl(Test2::Tools::Process) = 0.05
1 perl-Test2-Tools-Process = 0.05-1.fc35
1 perl(Test2::Tools::Process::Event)
1 perl(Test2::Tools::Process::Exec)
1 perl(Test2::Tools::Process::Exit)
1 perl(Test2::Tools::Process::Proc)
1 perl(Test2::Tools::Process::ReturnMultiLevel)
1 perl(Test2::Tools::Process::System)
1 perl(Test2::Tools::Process::SystemProc)
1 perl(Test::Exec) = 0.05
1 perl-Test-Exec = 0.05-1.fc35
Binary provides are Ok.
Binary requires and provides for perl-Test2-Tools-Process-tests are Ok.
$ rpmlint ./perl-Test2-Tools-Process*
perl-Test2-Tools-Process.noarch: W: spelling-error Summary(en_US) qx -> q, x, ex
perl-Test2-Tools-Process.noarch: W: spelling-error %description -l en_US readpipe -> read pipe, read-pipe, readership
perl-Test2-Tools-Process.noarch: W: spelling-error %description -l en_US qx -> q, x, ex
perl-Test2-Tools-Process.src: W: spelling-error Summary(en_US) qx -> q, x, ex
perl-Test2-Tools-Process.src: W: spelling-error %description -l en_US readpipe -> read pipe, read-pipe, readership
perl-Test2-Tools-Process.src: W: spelling-error %description -l en_US qx -> q, x, ex
perl-Test2-Tools-Process-tests.noarch: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 7 warnings.
Rpmlint is ok
The package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item.
Resolution:
Approved
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test2-Tools-Process Thank you for the review and the repository. I added the missing dependency. I will retire perl-Test-Exec once getting this one into a build root. perl-Test-Exec was retired. |