Bug 1961479

Summary:	Review Request: golang-github-deislabs-oras - OCI Registry As Storage
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Olivier Lemasle <o.lemasle>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	o.lemasle, package-review
Target Milestone:	---	Flags:	o.lemasle: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-29 01:05:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Davide Cavalca 2021-05-18 05:10:19 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-deislabs-oras/golang-github-deislabs-oras.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-deislabs-oras/golang-github-deislabs-oras-0.11.1-1.fc35.src.rpm

Description:

ORAS enables various client libraries to push OCI Artifacts to OCI Conformant
registries.

ORAS is both a CLI for initial testing and a Go Module to be included with
your CLI, enabling a native experience.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-05-18 05:10:22 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=68181919

Comment 2 Olivier Lemasle 2021-05-20 13:46:11 UTC

You can fix the broken test instead of removing it.

Actually, the error in content_test.go is caused by the test directory ".test" which is missing [1].
When running the tests with "make test", the ".test" directory is actually created before running the tests [2]

You can then replace in your spec:

rm pkg/content/content_test.go

by:

mkdir .test/


[1] https://github.com/deislabs/oras/blob/5bfe0ab04a0f6fcdc5de4294cc79fb5b2e23a9a5/pkg/content/content_test.go#L51
[2] https://github.com/deislabs/oras/blob/5bfe0ab04a0f6fcdc5de4294cc79fb5b2e23a9a5/scripts/test.sh#L7

Comment 3 Davide Cavalca 2021-05-20 15:18:05 UTC

Thanks!

Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-deislabs-oras/golang-github-deislabs-oras.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-deislabs-oras/golang-github-deislabs-oras-0.11.1-2.fc35.src.rpm

Changelog:
- Fix broken test

Comment 4 Olivier Lemasle 2021-05-20 15:37:05 UTC

- License ok
- Go import path ok
- Latest version packaged
- Builds in mock
- Conforms to Packaging Guidelines
- No rpmlint error
- Patch for containerd already included upstream

Package accepted

Comment 5 Davide Cavalca 2021-05-20 15:40:57 UTC

Thanks!

$ fedpkg request-repo golang-github-deislabs-oras 1961479
https://pagure.io/releng/fedora-scm-requests/issue/34129

Comment 6 Fedora Update System 2021-05-20 20:59:23 UTC

FEDORA-2021-6b2aa7b2a8 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6b2aa7b2a8

Comment 7 Fedora Update System 2021-05-21 03:41:58 UTC

FEDORA-2021-6b2aa7b2a8 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-6b2aa7b2a8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6b2aa7b2a8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-05-29 01:05:31 UTC

FEDORA-2021-6b2aa7b2a8 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.