Bug 1962135

Summary: [Upgrade from 2.6.2 to 4.8.0] kubevirt configMap migrations are not adopted
Product: Container Native Virtualization (CNV) Reporter: ibesso <ibesso>
Component: InstallationAssignee: Nahshon Unna-Tsameret <nunnatsa>
Status: CLOSED ERRATA QA Contact: ibesso <ibesso>
Severity: high Docs Contact:
Priority: high    
Version: 4.8.0CC: cnv-qe-bugs, nunnatsa, stirabos
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.8.0-359 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 14:32:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description ibesso 2021-05-19 11:32:56 UTC
Description of problem:
----------------------
After upgrade from 2.6.2 to 4.8.0, liveMigrationConfig fields from kubevirt-config configmap are not adopted by HCO into HCO CR.


Version-Release number of selected component (if applicable):
2.6.2 -> 4.8.0

How reproducible:
----------------
100% (jenkins upgrade pipeline or manually via UI).


Steps to Reproduce:
------------------
1. Install OCP 4.8.0.
2. Install CNV 2.6.2 (registry-proxy.engineering.redhat.com/rh-osbs/iib:69505).
3. Modify kubevirt-config configmap:
add "migrations" list:
migrations: |-
    parallelMigrationsPerCluster: "3"
    bandwidthPerMigration: "32Mi"
    completionTimeoutPerGiB: "444"
4. Upgrade CNV to 4.8.0 (registry-proxy.engineering.redhat.com/rh-osbs/iib:76196).
5. Check HCO CR and KubeVirt CR.


Actual results:
--------------
Both HCO CR and KubeVirt CR are using the default values for the liveMigrationConfig:

  liveMigrationConfig:
    bandwidthPerMigration: 64Mi
    completionTimeoutPerGiB: 800
    parallelMigrationsPerCluster: 5
    parallelOutboundMigrationsPerNode: 2
    progressTimeout: 150


Expected results:
----------------
The custom values entered to the configmap (step 3 in Steps to reproduce) should be used for the specific fields.
In practice, the expected liveMigrationConfig is:

  liveMigrationConfig:
    bandwidthPerMigration: "32Mi"
    completionTimeoutPerGiB: "444"
    parallelMigrationsPerCluster: "3"
    parallelOutboundMigrationsPerNode: 2
    progressTimeout: 150



Additional info:

Comment 1 Nahshon Unna-Tsameret 2021-05-27 08:26:43 UTC
Manually validated the fix with version v4.8.0-359; iid: registry-proxy.engineering.redhat.com/rh-osbs/iib:77886

Comment 2 ibesso 2021-05-27 21:24:29 UTC
Verified with a cluster installed from scratch CNV 4.8.0
---------------------------------------------------------
IIB image: registry-proxy.engineering.redhat.com/rh-osbs/iib:78099
HCO [v4.8.0-362]

I repeated the same scenario on 2.6.2 and then upgraded to 4.8.0.
This time, I had it all migrated properly.
Additionally, the automation test (post-upgrade validation) passed apart from the manual verification.

Moving to VERIFIED.

Comment 5 errata-xmlrpc 2021-07-27 14:32:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.8.0 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2920