Bug 1962269
| Summary: | Review Request: rust-pancurses - Curses libary for Rust that supports both Unix and Windows | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-08-04 22:45:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1961856 | ||
|
Description
Davide Cavalca
2021-05-19 16:11:42 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=68270549 Taking on this review request.
================================================================================
Package was generated with rust2rpm, which simplifies the review process:
- package builds and installs on rawhide without errors
- windows-specific dependencies are removed
- test suite is run and all tests pass
- latest version is packaged
- license tag matches upstream specification ("MIT") and is acceptable
There is one "cosmetic" issue: The value for the Summary tag is way too long.
Please trim it to some sensible length, something like:
Summary: Curses libary for Rust that supports both Unix and Windows
Please fix this before importing the package to Fedora. Other than that, package is APPROVED.
================================================================================
Note 1: You might want to "normalize" the changelog date format to the format that is used by rpmdev-bumpspec (i.e. drop time and timezone) for better compatibility with older RPM versions.
Note 2: If you're going to build this package for both rawhide and F34 (I assume you do), please also make sure to submit an update for rust-ncurses-5.101.0-2 (with the added ncurses-devel Requires) to F34. Otherwise it might not build there.
Thanks! $ fedpkg request-repo rust-pancurses 1962269 https://pagure.io/releng/fedora-scm-requests/issue/34120 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pancurses FEDORA-2021-a113b8ea6c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a113b8ea6c FEDORA-2021-a113b8ea6c has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a113b8ea6c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a113b8ea6c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-a113b8ea6c has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |