Bug 1962415
Summary: | duplicate zone information for in-tree PV after enabling migration | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Hemant Kumar <hekumar> |
Component: | Storage | Assignee: | melbeher |
Storage sub component: | Operators | QA Contact: | Wei Duan <wduan> |
Status: | CLOSED ERRATA | Docs Contact: | |
Severity: | medium | ||
Priority: | medium | CC: | aos-bugs, jsafrane |
Version: | 4.8 | ||
Target Milestone: | --- | ||
Target Release: | 4.8.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-07-27 23:09:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Comment 2
Jan Safranek
2021-05-20 13:19:31 UTC
Correction: the CSI volume topology is weird, it uses both topology.ebs.csi.aws.com/zone and topology.kubernetes.io/zone. Reading upstream PRs, adding topology.kubernetes.io/zone is intentional: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/773 https://github.com/kubernetes-sigs/aws-ebs-csi-driver/issues/729 We can fix the CSI translation library - when it translates nodeAffinity from CSI to in-tree, it should merge the two redundant nodeSelectorTerms into one, i.e. somewhere in https://github.com/kubernetes/kubernetes/blob/fed3a4520d99a2d99fd4ed0f7edf1ac79e7253e7/staging/src/k8s.io/csi-translation-lib/plugins/aws_ebs.go#L157 it seems that this duplication is by intention as per https://github.com/kubernetes/kubernetes/blob/fed3a4520d99a2d99fd4ed0f7edf1ac79e7253e7/staging/src/k8s.io/csi-translation-lib/plugins/in_tree_volume.go#L84-L86, which is used to translate the `nodeAffinity` in https://github.com/kubernetes/kubernetes/blob/fed3a4520d99a2d99fd4ed0f7edf1ac79e7253e7/staging/src/k8s.io/csi-translation-lib/plugins/in_tree_volume.go#L271-L274 Good point. Would you mind filing an issue upstream, so we can discuss there if it makes sense to squash the duplicities? Verified on 4.8.0-0.nightly-2021-06-09-023740 $ oc get pv pvc-07a7f7ba-ccfb-431c-bf51-d9104db14f42 NAME CAPACITY ACCESS MODES RECLAIM POLICY STATUS CLAIM STORAGECLASS REASON AGE pvc-07a7f7ba-ccfb-431c-bf51-d9104db14f42 1Gi RWO Delete Bound wduan-csi/mypvc-default-sc gp2 5m35s $ oc get pv pvc-07a7f7ba-ccfb-431c-bf51-d9104db14f42 -o yaml metadata: annotations: pv.kubernetes.io/provisioned-by: ebs.csi.aws.com ... nodeAffinity: required: nodeSelectorTerms: - matchExpressions: - key: topology.kubernetes.io/zone operator: In values: - us-east-2b - key: topology.kubernetes.io/region operator: In values: - us-east-2 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438 |