Bug 1962869

Summary:	Make vagrant support ed25519 keys
Product:	[Fedora] Fedora	Reporter:	Philipp Trulson <philipp>
Component:	vagrant	Assignee:	Jarek Prokop <jprokop>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jprokop, lmohanty, madam, mike, pvalena, strzibny, thrcka, vondruch
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vagrant-2.2.19-8.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-01-09 09:43:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1984466, 2087076
Bug Blocks:

Description Philipp Trulson 2021-05-20 17:02:16 UTC

Description of problem:

We tried switching our RSA keys in Vagrant with a new ed25519 key because of another bug (https://github.com/hashicorp/vagrant/issues/12344), however that doesn't work on Fedora and I'm a bit confused about the reason. When I look at the spec file (https://src.fedoraproject.org/rpms/vagrant/blob/f34/f/vagrant.spec) there seems to be a special condition "%bcond_with ed25519". Can I see anywhere if this condition is true or false? To me it looks like it's disabled because the patch on line 178 is applied on my system, ed25519 support is disabled. I also can't find a package with the ed25519 rubygem. Can you maybe make it work?


Version-Release number of selected component (if applicable): 2.2.16-1.fc34


How reproducible: Always


Steps to Reproduce:
1. Configure a Vagrant box with an ed25519 SSH key
2. Do 'vagrant up'

Actual results:

> The private key you're attempting to use with this Vagrant box uses 
> an unsupported encryption type. The SSH library Vagrant uses does not support 
> this key type. Please use `ssh-rsa` or `ssh-dss` instead. Note that 
> sometimes keys in your ssh-agent can interfere with this as well, 
> so verify the keys are valid there in addition to standard 
> file paths.


Expected results:

A working box with the new key

Comment 1 Pavel Valena 2021-05-21 17:27:12 UTC

Hello,

the gem will be used when it's available installed, it will be installed when it's available in Fedora repository. It is not packaged as of now. The bcond affects hard/soft requirement of the package, some integration testing and live patching (nothing important I think).

I have ed25519 gem prepared in my COPR repository:

  https://copr.fedorainfracloud.org/coprs/pvalena/vagrant/

Please give it a go, and let me know if it works for you. I'll file a new package review request with it.

Comment 2 Ben Cotton 2022-05-12 16:55:12 UTC

This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 3 Ben Cotton 2022-08-09 13:37:45 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 4 Jarek Prokop 2022-12-05 17:29:03 UTC

Hi, all required bits are in rawhide, the last piece of the puzzle is adjusting requirements of vagrant package itself, I'll leave this ticket open until we get to that point.

To use ed25519 keys with custom vagrant boxes, make sure you have rubygem-net-ssh-6.1.0-6.fc38 and rubygem-ed25519 installed.

With these 2 dependencies you should be able to `vagrant ssh` into machines with ed25519 keys. I have been successful in my limited testing of this feature.

Comment 5 Fedora Update System 2023-01-09 09:40:54 UTC

FEDORA-2023-ec37649396 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ec37649396

Comment 6 Fedora Update System 2023-01-09 09:43:05 UTC

FEDORA-2023-ec37649396 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.