Bug 1963154
Summary: | Current BMAC reconcile flow skips Ironic's deprovision step | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Flavio Percoco <fpercoco> |
Component: | assisted-installer | Assignee: | Flavio Percoco <fpercoco> |
assisted-installer sub component: | assisted-service | QA Contact: | Yuri Obshansky <yobshans> |
Status: | CLOSED ERRATA | Docs Contact: | |
Severity: | high | ||
Priority: | high | CC: | alazar, aos-bugs, asegurap, ccrum, ncarboni, rfreiman |
Version: | 4.8 | ||
Target Milestone: | --- | ||
Target Release: | 4.8.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | AI-Team-Platform KNI-EDGE-4.8 | ||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-07-27 23:09:41 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Flavio Percoco
2021-05-21 15:14:03 UTC
On the open questions: - My understanding is that the URL does not change, is that right @ncarboni ? - I don't think we should support that. Only BMAC should be doing that. (In reply to Antoni Segura Puimedon from comment #1) > On the open questions: > - My understanding is that the URL does not change, is that right > @ncarboni ? Yeah, the URL never changes. That statement was more a "thought provoke" kind of statement rather than an actual proposal. I have found a workflow that may work for our case: Trigger the deprovision (and subsequently re-set the image) when the ImageCreated condition date in the `InfraEnv` resource is newer than the `Provision` status in the BMH. I need to study and test this workflow a bit better as I fear there may be a corner case where the user may trigger the above workflow accidentally. > - I don't think we should support that. Only BMAC should be doing that. I agree with you :) > Yeah, the URL never changes.
So, the base URL never changes but the signature does since AI generates a new one on every image change. We can use that to check when an image has changed, but this workflow will require Auth to be enabled.
(In reply to Antoni Segura Puimedon from comment #1) > On the open questions: > - My understanding is that the URL does not change, is that right > @ncarboni ? Sounds like this is sorted out now. Removing needinfo Validated this works on OCP 4.8.0-rc.0 hub + ACM downstream 2.3.0-DOWNSTREAM-2021-06-17-01-26-58 Tested as follows: - Created CRs for SNO cluster as usual - Confirmed infraenv and BMH both had discovery iso url with the following api key (After provisioning completed by bmh) isoDownloadURL: https://assisted-service-rhacm.apps.ocp-edge-cluster-assisted-0.qe.lab.redhat.com/api/assisted-install/v1/clusters/bba138ad-b983-46d1-ab69-71a168d56665/downloads/image?api_key=eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVz dGVyX2lkIjoiYmJhMTM4YWQtYjk4My00NmQxLWFiNjktNzFhMTY4ZDU2NjY1In0.ypFbmGR7Nv792qjCfLRaVwQm-u83ZScukTHa0Ioc9SUnmqGkc7kaLTSBI7zsVLdiW1SdVATHsAJ0y7fEElHJmQ - Moments after provisioning completed and VM was started via ironic, I re-applied the infraenv with an ignition config override which caused the discovery iso to be rebuilt - The BMH was deprovisioned and then began to reprovision. After reprovision I Checked both the infraenv and bmh and there was a new api key on the discovery url: isoDownloadURL: https://assisted-service-rhacm.apps.ocp-edge-cluster-assisted-0.qe.lab.redhat.com/api/assisted-install/v1/clusters/bba138ad-b983-46d1-ab69-71a168d56665/downloads/image?api_key=eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVz dGVyX2lkIjoiYmJhMTM4YWQtYjk4My00NmQxLWFiNjktNzFhMTY4ZDU2NjY1In0.QVMpNKMeKiFjFtIUxgyVHH8YSHStpBch5Fo--W2_WmRCjAo0YuU4dFzYw_s3KVkeUk3y-GvurNGBaYN2nM-HyA Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438 |