Bug 1963215

Summary:	Fast forward action is bound to SHIFT not TAB in latest Fedora release
Product:	[Fedora] Fedora	Reporter:	Adam Peterson <mail>
Component:	openttd	Assignee:	Felix Kaechele <felix>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	34	CC:	felix
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	openttd-1.11.2-3.fc33 openttd-1.11.2-3.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-31 00:47:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Peterson 2021-05-21 17:05:40 UTC

Description of problem:
Pressing the shift key during game play causes incorrect behavior that should be bound to the tab key instead. This is not able to be corrected by the user.

Version-Release number of selected component (if applicable):
1.11.2

How reproducible:
Was able to reproduce on multiple machines. Downgrading to previous package with version 1.10.3 eliminates the bug.

Steps to Reproduce:
1. Install the latest openttd package on Fedora Workstation 34
2. Run openttd and start a new game.
3. Press shift key.

Actual results:
Tab key does not seem to be bound to anything. Holding the shift key still enables cost estimation, but the game fast forwards at the same time.

Expected results:
Pressing the tab key fast forwards the game, while pressing the shift key gives cost estimate of construction below the cursor. 

Additional info:
The openttd developers mention this is an issue in the Fedora package(s). Quoting their responses to the issue:

> Could well be an issue with the fedora packages then - the default (release -> debug) was changed when we switched from a configure script to cmake, so it would be easily overlooked

> https://src.fedoraproject.org/rpms/openttd/blob/rawhide/f/openttd.spec#_57 - doesn't set a BUILD_TYPE, which defaults to debug mode (which uses shift as FFWD)

Comment 1 Felix Kaechele 2021-05-22 00:47:03 UTC

Excellent catch! Your detailed bug report saved me a lot of time and headache finding the fix, so thanks for that. Update queued.

Comment 2 Fedora Update System 2021-05-22 01:19:19 UTC

FEDORA-2021-8f7b48b2c0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f7b48b2c0

Comment 3 Fedora Update System 2021-05-22 01:19:19 UTC

FEDORA-2021-ea2cba831b has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ea2cba831b

Comment 4 Fedora Update System 2021-05-22 01:19:20 UTC

FEDORA-2021-30912f40f3 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-30912f40f3

Comment 5 Fedora Update System 2021-05-23 01:36:51 UTC

FEDORA-2021-30912f40f3 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-30912f40f3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-30912f40f3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-05-23 01:50:05 UTC

FEDORA-2021-8f7b48b2c0 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8f7b48b2c0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f7b48b2c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-05-23 02:11:48 UTC

FEDORA-2021-ea2cba831b has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-ea2cba831b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ea2cba831b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-05-31 00:47:14 UTC

FEDORA-2021-8f7b48b2c0 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2021-05-31 01:04:20 UTC

FEDORA-2021-30912f40f3 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.