Bug 1964426

Summary:	[External Mode] Default ceph-rbd-thick storage class is not created
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Jilju Joy <jijoy>
Component:	ocs-operator	Assignee:	arun kumar mohan <amohan>
Status:	VERIFIED ---	QA Contact:	Sidhant Agrawal <sagrawal>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.8	CC:	amohan, mbukatov, muagarwa, sagrawal, sostapov
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	OCS 4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.8.0-432.ci	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jilju Joy 2021-05-25 13:25:30 UTC

Description of problem (please be detailed as possible and provide log
snippests):
ocs-external-storagecluster-ceph-rbd-thick storage class is not created during OCS 4.8 external mode installation. This is a new storage class (added in OCS 4.8) with thick provision enabled that should be created in addition to the default RBD storage class.


External mode deployment is blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1963134 but the storage class creation stage has passed.

Please note that the details and logs shared below are same as that shared in the bug 1963134.


$ oc get sc
NAME                                   PROVISIONER                             RECLAIMPOLICY   VOLUMEBINDINGMODE   ALLOWVOLUMEEXPANSION   AGE
ocs-external-storagecluster-ceph-rbd   openshift-storage.rbd.csi.ceph.com      Delete          Immediate           true                   145m
ocs-external-storagecluster-ceph-rgw   openshift-storage.ceph.rook.io/bucket   Delete          Immediate           false                  145m
ocs-external-storagecluster-cephfs     openshift-storage.cephfs.csi.ceph.com   Delete          Immediate           true                   145m
openshift-storage.noobaa.io            openshift-storage.noobaa.io/obc         Delete          Immediate           false                  143m
thin        


ocs-external-storagecluster-ceph-rbd-thick is not present in the list of storage class.

must-gather logs: 
http://magna002.ceph.redhat.com/ocsci-jenkins/openshift-clusters/j014vu1ce33-t4an/j014vu1ce33-t4an_20210521T103434/logs/failed_testcase_ocs_logs_1621594049/test_deployment_ocs_logs/

=========================================================================
Version of all relevant components (if applicable):
OCP: 4.8.0-0.nightly-2021-05-19-123944
OCS: ocs-operator.v4.8.0-399.ci
External RHCS: ceph version 14.2.11-146.el8cp (c5c2c77b05b124fcbbe81df2cd4b3739215f88ad) nautilus (stable)


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
Storage class which can be used to create RBD thick provisioned PVC is not present.

Is there any workaround available to the best of your knowledge?
Manually create storage class

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
Yes

Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:
ceph-rbd-thick storage class is newin OCS 4.8

Steps to Reproduce:
1. Deploy an OCP cluster
2. Install OCS 4.8 External mode
3. Check the presence of ocs-external-storagecluster-ceph-rbd-thick storage class.


Actual results:
ocs-external-storagecluster-ceph-rbd-thick storage class is not present

Expected results:
ocs-external-storagecluster-ceph-rbd-thick storage class should be present

Additional info:

Comment 2 Mudit Agarwal 2021-06-04 16:52:38 UTC

Arun, will you have b/w to send a PR for this?

Comment 3 Martin Bukatovic 2021-06-07 20:51:41 UTC

Providing QA ack based on today's bug triage.

Comment 6 arun kumar mohan 2021-06-08 06:06:35 UTC

Taking a look at this...

Comment 7 arun kumar mohan 2021-06-09 19:43:43 UTC

Submitted a PR: https://github.com/openshift/ocs-operator/pull/1217

Jose please take a look.

Comment 9 Mudit Agarwal 2021-06-22 09:22:17 UTC

Sidhant, what is the expected name of blockpool for external clusters irrespective of the provisioning type ?
AFAIU, this should fail for thin provisioning class also with the same reason.

Comment 11 Mudit Agarwal 2021-06-22 12:13:40 UTC

Thanks Sidhant.

From ocs-op side it looks fine because that's the standard pool name ocs-operator will generate.
I guess the thick sc lacks the availability of taking a pool name from the external script.

Arun, PTAL

Comment 12 arun kumar mohan 2021-06-22 17:38:35 UTC

Created another PR : https://github.com/openshift/ocs-operator/pull/1234

Got a fancy PR number... (=