Bug 1965552

Summary: warn user that all virtio-win related settings will be lost after removing virtio-win package
Product: Red Hat Enterprise Linux 8 Reporter: Vadim Rozenfeld <vrozenfe>
Component: virtio-winAssignee: Vadim Rozenfeld <vrozenfe>
virtio-win sub component: distribution QA Contact: leidwang <leidwang>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: unspecified    
Priority: unspecified CC: ailan, jinzhao, juzhang, leidwang, lijin, mdean, menli, mtessun, sgoodman
Version: 8.6Keywords: RFE, Triaged
Target Milestone: beta   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-23 08:37:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vadim Rozenfeld 2021-05-28 02:18:56 UTC
Description of problem:
Currently user is not explicitly warned that all virtio-win drivers related settings will be lost after virtio-win package removal.

Version-Release number of selected component (if applicable):


How reproducible:
install and uninstall virtio-win package changing DHCP settings as described in https://bugzilla.redhat.com/show_bug.cgi?id=1898985

Steps to Reproduce:
1.
2.
3.

Actual results:
the setting will lost without any warning.

Expected results:
The user needs to be warned that after un-installing virtio-win package all virtio-win drivers' related settings will be lost. 

Additional info:

Comment 11 Vadim Rozenfeld 2021-08-04 06:33:22 UTC
I added the new screenshorts of the VerifyReady dialog

https://bugzilla.redhat.com/attachment.cgi?id=1810716
when the checkbox is unchecked ("Remove" pushbutton disabled) 

and https://bugzilla.redhat.com/attachment.cgi?id=1810717
when checkbox is checked ("Remove" button is enabled) 

the unmerged code changes can be found at
https://github.com/vrozenfe/virtio-win-guest-tools-installer/commit/48761339a10a9389622c0b830f07e58a65df7c49

Any comments or suggestions are welcome.

Thanks,
Vadim.

Comment 14 Vadim Rozenfeld 2021-08-16 05:23:21 UTC
committed upstream
https://github.com/virtio-win/virtio-win-guest-tools-installer/pull/20

Comment 19 leidwang@redhat.com 2021-08-31 03:21:35 UTC
Hi Vadim, I see that the bug status has changed to 'MODIFIED', but the corresponding package cannot be found. Can you provide an rpm package? Thanks in advance!

Comment 20 Vadim Rozenfeld 2021-08-31 04:29:30 UTC
(In reply to leidwang from comment #19)
> Hi Vadim, I see that the bug status has changed to 'MODIFIED', but the
> corresponding package cannot be found. Can you provide an rpm package?
> Thanks in advance!

Unfortunately the virtio-win installer build failed due to the build
VM problems https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=39383502
I will update the bug with the relevant build information as soon as the problem
has been resolved.

Best regards,
Vadim.

Comment 21 Vadim Rozenfeld 2021-09-01 01:23:43 UTC
please give a try to installer from 1.9.18.1 virtio-win rpm which is available at 
http://brew-task-repos.usersys.redhat.com/repos/official/virtio-win/1.9.18/1.el8/noarch/

thanks,
Vadim.

Comment 22 leidwang@redhat.com 2021-09-01 03:11:51 UTC
Tested this case with virtio-win-1.9.18.iso and it works as expected.
When I wanted to remove "virtio-win-driver-installer", I received a warning message.

Comment 26 menli@redhat.com 2021-09-01 07:41:38 UTC
Test installer related cases with virtio-win-1.9.18-1.el8.iso, found gagent version is not right, expected is 102.7.0 but got 102.0.3.

Comment 27 Vadim Rozenfeld 2021-09-01 09:11:48 UTC
(In reply to menli from comment #26)
> Test installer related cases with virtio-win-1.9.18-1.el8.iso, found gagent
> version is not right, expected is 102.7.0 but got 102.0.3.

Thanks,
let me check it and build a new rpm if needed.

Comment 28 leidwang@redhat.com 2021-09-01 09:16:04 UTC
No warning message when upgrade installer from previous, we need that warning for upgrade as well.

Comment 29 Vadim Rozenfeld 2021-09-01 09:36:03 UTC
(In reply to leidwang from comment #28)
> No warning message when upgrade installer from previous, we need that
> warning for upgrade as well.

Oh, no. It will not work for the prior installers that were built before 
8.5.0 because the old installers don't have this feature.

Comment 32 Vadim Rozenfeld 2021-09-03 03:05:23 UTC
(In reply to menli from comment #26)
> Test installer related cases with virtio-win-1.9.18-1.el8.iso, found gagent
> version is not right, expected is 102.7.0 but got 102.0.3.

the new rpm/ installer virtio-win-1.9.18-2.el8 is ready for testing 

Thanks,
Vadim.

Comment 33 leidwang@redhat.com 2021-09-08 03:40:02 UTC
Hi Vadim,
Now this warning message can only be seen through msi, not through exe, but customer uses exe. 
Do you have any comments about that?

Comment 36 leidwang@redhat.com 2021-09-17 07:36:23 UTC
Based on comment35,filed a new bz2005220,and set this bz to VERIFIED.Thanks!