Bug 1965672
| Summary: | Review Request: heroic-games-launcher - Heroic is an Open Source Game Launcher for Linux | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rémi Lauzier <remilauzier> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | eclipseo, package-review, remilauzier |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-29 18:52:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rémi Lauzier
2021-05-28 19:42:56 UTC
i have done the maximum i was able to do but the package as some flaws i can't correct for now. It need internet access during build and the program crash immediately. I am not even sure if it's really a good idea to package it for fedora. If somebody with better experience packaging yarn program can help thanks. https://download.copr.fedorainfracloud.org/results/remilauzier/heroic-games-launcher/fedora-rawhide-x86_64/02215043-heroic-games-launcher/heroic-games-launcher.spec https://download.copr.fedorainfracloud.org/results/remilauzier/heroic-games-launcher/fedora-rawhide-x86_64/02215043-heroic-games-launcher/heroic-games-launcher-1.7.0-1.fc35.src.rpm - Provides: bundled(libffmpeg) This is not allowed. ffmpeg is covered by patents which makes it not packageable in Fedora. FFMPEG is packaged in RPMFusion instead. If you want to package it, propose it to RPMFusion. Also, requiring internet access during build is not ok, it is not available in Koji. - You would need to unbundle all of this: Provides: bundled(libffmpeg) Provides: bundled(libEGL) Provides: bundled(libGLESv2) Provides: bundled(libvk_swiftshader) - Generally, electron apps are not packaged in Fedora due to the huge mess it is. - Atim packaged it in https://copr.fedorainfracloud.org/coprs/atim/heroic-games-launcher/package/heroic-games-launcher-bin/ based off the official RPM package, so not bothering with electron in its spec. However since it includes FFMPEG, it is not allowed in COPR too. I have tried making it work without ffmpeg and it didn't work, and it need internet access to download a thousand of dependencies, so i will closed the review. packaging electron apps is too hard for me. Will use flatpak or something else instead. Thanks for your review and your time. |