Bug 196570
Summary: | Review Request: mirage | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael J Knox <michael> |
Component: | Package Review | Assignee: | Thorsten Leemhuis (ignored mailbox) <bugzilla-sink> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | kevin, mtasaka, panemade |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-16 20:35:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Michael J Knox
2006-06-25 00:07:17 UTC
Not an official review as I'm not yet sponsored Mock build for development i386 is failed Add BuildRequires: desktop-file-utils MUST Items: - MUST: rpmlint shows no error - MUST: dist tag is present - MUST: The package is named according to the Package Naming Guidelines. - MUST: The spec file name matching the base package mirage, in the format mirage.spec - MUST: This package meets the Packaging Guidelines. - MUST: The package is licensed with an open-source compatible license GPL. - MUST: The License field in the package mirage.spec file matches the actual license file COPYING in tarball. - MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct. - MUST: This package have a %clean section, which contains rm -rf %{buildroot}. - MUST: This package used macros. - MUST: Document files are included like README. - MUST: Library files that end in .so (without suffix) are NOT in a -devel package. - MUST: This package contains shared library files located in the dynamic linker's default paths, and But this package did NOT calling ldconfig in %post and %postun. * Source URL is present and working. * BuildRoot is correct BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires is NOT correct What you Need to Do:- * As your package uses .so files. You can add subpackage -devel. * BuildRequires needed desktop-file-utils to be added. * add %post %postun sections with call to ldconfig as %post -p /sbin/ldconfig %postun -p /sbin/ldconfig * update-desktop-database dependancy missing for %post (package desktop-file-utils) as well as for %postun (package desktop-file-utils) Update. However, I am not going to split our the shared objects as there are no header file or pkgconfig files. It seems very much pointless to split them out. I will discuss this on the fedora-packaging list for further clarification. Spec URL: http://www.knox.net.nz/~michael/mirage.spec SRPM URL: http://www.knox.net.nz/~michael/mirage-0.7-2.src.rpm * %{_datadir}/%{name} is unowned * %doc files are duplicated in %{_datadir}/%{name}, but not used at run-time > As your package uses .so files. You can add subpackage -devel. No, surely not in this case. This is a C shared library Python extension module. Moving it into a -devel package would be wrong and would break the Python application. > add %post %postun sections with call to ldconfig as > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig Negative. The package does NOT store any shared libs in dynamic linker's search paths, but only in Python sitearch. Further, "-p /sbin/ldconfig" would not work when the scriptlet contained a body which to execute in a shell. Option "-p" specifies the scriptlet interpreter explicitly (default is -p /bin/sh). OK, fixed that up, thanks. thanks Michael Schwendt for your comments Hey Michael. I would be happy to formally review this. Before I do: Are the links in comment #2 current? Or did you make changes in comment #4 that aren't reflected yet in the spec? Also, it looks like moving forward the python guidelines are going to change to require .pyo files to just be included instead of ghosting them. https://www.redhat.com/archives/fedora-maintainers/2006-August/msg00018.html Can you make that change as well? Hey, just a quick ping to let you know that I am alive, just still in the throws of unpacking/new job/etc etc. I hope to tidy this review up before/by the end of the week. Thanks for your patience. Given your recent announcement, do you still wish to continue with the submission of this package? Sorry. Due to my stepping out for a while, I am unable to complete this submission. *** This bug has been marked as a duplicate of 216282 *** |