Bug 196621
| Summary: | Review Request: perl-IO-Digest - Perl module to calculate digests while reading or writing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Burrell <ianburrell> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-29 06:54:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 196623 | ||
| Bug Blocks: | 163779, 196629 | ||
|
Description
Ian Burrell
2006-06-26 01:54:41 UTC
Fixed rpmlint warnings. http://znark.com/fedora/perl-IO-Digest-0.10.spec http://znark.com/fedora/perl-IO-Digest-0.10-3.src.rpm I cannot fetch the spec via that URL. I can get the srpm fine, however. You have a duplicated dependency on PerlIO::via::dynamic. Since you've just packaged this, I think it safe to say that the necessary version is in Extras and the dependency can be dropped. Otherwise you'll need to filter. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 0448841e0559c2c19c7e8001ef087e26 IO-Digest-0.10.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. X a duplicated dependency: perl(IO::Digest) = 0.10 perl-IO-Digest = 0.10-3.fc6 = perl >= 0:5.008 perl(:MODULE_COMPAT_5.8.8) perl(Digest) X perl(PerlIO::via::dynamic) X perl(PerlIO::via::dynamic) >= 0.10 perl(strict) perl(warnings) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=2, Tests=4, 0 wallclock secs ( 0.04 cusr + 0.04 csys = 0.08 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. Fixed duplicated dependency. Spec: http://znark.com/fedora/perl-IO-Digest.spec SRPMS: http://znark.com/fedora/perl-IO-Digest-0.10-4.src.rpm The duplicated dependency is indeed fixed. APPROVED Built for devel. Package Change Request ====================== Package Name: perl-IO-Digest New Branches: EL-4 EL-5 cvs done. Package Change Request ====================== Package Name: perl-IO-Digest New Branches: EL-4 EL-5 I don't see the EL-4 and EL-5 branches for perl-IO-Digest and it has been a whole day. sorry about that... try now? |