Bug 196635
| Summary: | Review Request: knetworkmanager | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Keywords: | Reopened |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-29 11:32:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Dennis Gilmore
2006-06-26 05:05:16 UTC
Offhand, first thing to fix is to fix Release tag, use instead (something
like):
Release: 0.1.%{svn}%{?dist}
Is there a reason to use a cvs/svn checkout instead of an official release?
If so, please document that as a comment in the specfile.
Also, please document (as comment or whatever) the purpose of of any applied
patches.
Nevermind about the "official release" but, it appears there isn't one (yet), afaict. * Mon Jun 27 2006 <dennis> - 0.1-0.1svn20060626 - fix BuildRequires missing hal-devel, fix version to match - fedora guidelines, add comment about patch Bad SuSE SRPM: http://ausil.us/packages/knetworkmanager-0.1-0.1svn20060625.src.rpm SPEC: http://ausil.us/packages/knetworkmanager.spec Need a dot '.' between 0.1 and svn... bits in the Release tag. * Mon Jun 27 2006 <dennis> - 0.1-0.2.svn20060626 - add a . to the release SRPM: http://ausil.us/packages/knetworkmanager-0.1-0.2.svn20060625.src.rpm SPEC: http://ausil.us/packages/knetworkmanager.spec As per our IRC chat, patch to use system-config-network instead of (the hard-coded) yast, and then it's looking pretty good. * Mon Jun 27 2006 <dennis> - 0.1-0.3.svn20060626 - patch out call to yast and replace with - system-config-network for dialup SRPM: http://ausil.us/packages/knetworkmanager-0.1-0.3.svn20060625.src.rpm SPEC: http://ausil.us/packages/knetworkmanager.spec Looks good, APPROVED. imported branch requested all built and awaiting push Closing |