Bug 1966581

Summary: Failed migration hook status is "Active" in the Migration Resources tree in the web console
Product: Migration Toolkit for Containers Reporter: Sergio <sregidor>
Component: GeneralAssignee: Derek Whatley <dwhatley>
Status: CLOSED ERRATA QA Contact: Xin jiang <xjiang>
Severity: medium Docs Contact: Avital Pinnick <apinnick>
Priority: medium    
Version: 1.5.0CC: ernelson, rjohnson, whu, xjiang
Target Milestone: ---   
Target Release: 1.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-28 04:08:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description Sergio 2021-06-01 12:53:53 UTC
Created attachment 1788501 [details]
screenshot

Description of problem:
When a migration fails because a hook has failed, if we look at the migration resources list the hook that failed is still reported as Active.

Version-Release number of selected component (if applicable):
MTC 1.5.0

How reproducible:
Always

Steps to Reproduce:
1. Create an empty namespace in the source cluster

oc new-project bz-test


2. Create a migration plan for this namespace and add a PreBackup hook that will always fail. We can use "openshift-migration" namespace and "migration-controller" SA to run the hook and run it in the source cluster.

Hook example:

- hosts: localhost
  tasks:
  - fail:
      msg: "Always fail"

3. Run the migration

4. When the migration fails click on "Migration resources"

Actual results:
The migration resources list will show the hook job as "Active", even if it failed and the migration finished.

Expected results:
Since the job was already executed and failed, and the migration is finished too, the job for the hook should not be displayed as an active resource in the list.

Additional info:
Attached a screenshot showing the Active Job resource in a finalized and failed migration plan.

Comment 5 whu 2021-06-24 11:42:11 UTC
Verified against MTC 1.5.0 stage image: 
registry.stage.redhat.io/rhmtc/openshift-migration-rhel7-operator@sha256:17d819f0c28828bc5095bf917563388e05144e2bbbe9c0c86810b350425ee341

Comment 11 errata-xmlrpc 2021-07-28 04:08:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) image release advisory 1.5.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2929