Bug 1966617

Summary:	Default HiveConfig CR on ACM 2.3.0 will not work properly with Assisted Installer
Product:	Red Hat Advanced Cluster Management for Kubernetes	Reporter:	Juan Manuel Parrilla Madrid <jparrill>
Component:	Cluster Lifecycle	Assignee:	James Talton <jtalton>
Status:	CLOSED NOTABUG	QA Contact:	Derek Ho <dho>
Severity:	high	Docs Contact:	Christopher Dawson <cdawson>
Priority:	high
Version:	rhacm-2.3	CC:	ccrum, hanzhang, pablo.iranzo
Target Milestone:	---	Flags:	ming: rhacm-2.3+
Target Release:	rhacm-2.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-03 13:54:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1958966

Description Juan Manuel Parrilla Madrid 2021-06-01 14:07:06 UTC

Description of the problem:

On manual testing of ACM Downstream bits, we see that the HiveConfig submitted by the ACM Operator is not fully correct in order to make it work with Assisted Installer:

ACM Version Tested:
- acm-custom-registry: 2.3.0-DOWNSTREAM-2021-05-27-19-55-15
- acm-operator-bundle: v2.3.0-111

The CR does not contain the appropriate FeatureGate (AlphaAgentInstallStrategy) to work with the ClusterDeployments.


Operator snapshot version:

- acm-custom-registry: 2.3.0-DOWNSTREAM-2021-05-27-19-55-15

OCP version:

Client Version: 4.8.0-0.nightly-2021-05-25-072938
Server Version: 4.8.0-0.nightly-2021-05-25-072938
Kubernetes Version: v1.21.0-rc.0+ee60d07


Browser Info:

Steps to reproduce:
1. Deploy ACM Downstream version on top of OCP
2. Create the AI Operand 
3. Create AgentClusterInstall and a ClusterDeployment


Actual results:
It fails getting requiring the AlphaAgentInstallStrategy featureGate to be enabled

Expected results:
ClusterDeployment does not get created.

Additional info:

Yaml Manifest required:
---
apiVersion: hive.openshift.io/v1
kind: HiveConfig
metadata:
  name: hive
spec:
 featureGates:
   custom:
     enabled:
     - AlphaAgentInstallStrategy
   featureSet: Custom
 logLevel: debug
 targetNamespace: hive

OR

Patch Command t be executed:

oc patch hiveconfig hive --type merge -p '{"spec":{"targetNamespace":"hive","logLevel":"debug","featureGates":{"custom":{"enabled":["AlphaAgentInstallStrategy"]},"featureSet":"Custom"}}}'

Comment 1 hanzhang 2021-06-03 13:54:50 UTC

Hi Juan,

Thanks for reporting. Currently in 2.3, it's required for users to manually patch hiveconfig with the patch command you mentioned. 
The steps will also be in our 2.3 doc. 

Thanks