Bug 1966989

Summary:	[master] Missing value-filling of log line in assisted-service operator pod
Product:	OpenShift Container Platform	Reporter:	Osher De Paz <odepaz>
Component:	assisted-installer	Assignee:	David Zager <dzager>
assisted-installer sub component:	Deployment Operator	QA Contact:	Osher De Paz <odepaz>
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	low
Priority:	medium	CC:	dzager
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:	AI-Team-Platform
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1970494 (view as bug list)		Environment:
Last Closed:	2022-08-28 08:45:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1970494

Description Osher De Paz 2021-06-02 10:10:30 UTC

Description of problem:
We don't fill-in value of ConfigMap name in one log line:

time="2021-05-31T13:22:29Z" level=info msg="Assisted service deployment created" agent_service_config=agent agent_service_config_namespace= go-id=466 request_id=fbbacd75-459e-4fc0-98f8-02ffa3f00e54
time="2021-05-31T13:22:29Z" level=info msg="AgentServiceConfig Reconcile ended" agent_service_config=agent agent_service_config_namespace= go-id=466 request_id=fbbacd75-459e-4fc0-98f8-02ffa3f00e54
time="2021-05-31T13:24:50Z" level=info msg="AgentServiceConfig Reconcile started" agent_service_config=agent agent_service_config_namespace= go-id=466 request_id=f9341cc5-2f07-450b-a28e-a5b70871d31a
time="2021-05-31T13:24:50Z" level=info msg="ConfigMap %v being used to configure assisted-service deploymentassisted-service-config" agent_service_config=agent agent_service_config_namespace= go-id=466 request_id=f9341cc5-2f07-450b-a28e-a5b70871d31a

Look at https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/18913/rehearse-18913-pull-ci-openshift-assisted-service-ocm-2.3-e2e-metal-assisted-operator-ztp/1399331146914861056/artifacts/e2e-metal-assisted-operator-ztp/baremetalds-assisted-operator-gather/artifacts/assisted-service-operator.log

Comment 1 bjacot 2021-06-08 21:08:59 UTC

Osher can you verify this since you logged the issue.  It's unclear how to reproduce this issue.

Comment 2 Osher De Paz 2021-06-09 04:50:45 UTC

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_assisted-service/1946/pull-ci-openshift-assisted-service-master-e2e-metal-assisted-operator-ztp/1402356110018482176/artifacts/e2e-metal-assisted-operator-ztp/baremetalds-assisted-operator-gather/artifacts/assisted-service-operator.log

That's from log files of the e2e-metal-assisted-operator-ztp job of the PR

So it looks good

Comment 3 David Zager 2021-06-10 14:46:59 UTC

Must be in modified for https://github.com/openshift/assisted-service/pull/1966 to be properly linked and fix included in the ocm-2.3 branch (for 4.8.0).