Bug 1967104

Summary:	[4.8.0] InfraEnv ctrl: log the amount of NMstate Configs baked into the image
Product:	OpenShift Container Platform	Reporter:	Nir Magnezi <nmagnezi>
Component:	assisted-installer	Assignee:	Nir Magnezi <nmagnezi>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	alazar, aos-bugs, mfilanov, nshidlin, yobshans
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Hive KNI-EDGE-4.8
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1967102	Environment:
Last Closed:	2021-07-27 23:11:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1967102
Bug Blocks:

Description Nir Magnezi 2021-06-02 12:46:18 UTC

+++ This bug was initially created as a clone of Bug #1967102 +++

Description of problem:
=======================
The infraEnv controller doesn't have a way to know how many NMStateConfigs to anticipate.

Since the controller watches for NMStateConfig changes and invokes image regeneration per each NMStateConfig addition/removal/update, it would help to log the amount of NMStateConfigs in each image generation.

Comment 3 nshidlin 2021-06-17 17:28:33 UTC

Verified on 2.3.0-DOWNSTREAM-2021-06-17-01-26-58:

time="2021-06-17T17:26:57Z" level=info msg="InfraEnv Reconcile started" func="github.com/openshift/assisted-service/internal/controller/controllers.(*InfraEnvReconciler).Rec
oncile" file="/remote-source/app/internal/controller/controllers/infraenv_controller.go:80" go-id=1092 infra_env=sno-0-infraenv infra_env_namespace=rhacm request_id=768fcc99
-5a00-4104-9a4b-605afd48b756                                                                                                                                                 
time="2021-06-17T17:26:57Z" level=info msg="the amount of nmStateConfigs included in the image is: 1" func="github.com/openshift/assisted-service/internal/controller/control
lers.(*InfraEnvReconciler).ensureISO" file="/remote-source/app/internal/controller/controllers/infraenv_controller.go:286" go-id=1092 infra_env=sno-0-infraenv infra_env_name
space=rhacm request_id=768fcc99-5a00-4104-9a4b-605afd48b756

Comment 5 errata-xmlrpc 2021-07-27 23:11:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438