Bug 1967321
| Summary: | metrics role can't be re-run if the Grafana admin password has been changed | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Brian Smith <briasmit> | |
| Component: | rhel-system-roles | Assignee: | Rich Megginson <rmeggins> | |
| Status: | CLOSED ERRATA | QA Contact: | Jan Kurik <jkurik> | |
| Severity: | unspecified | Docs Contact: | Gabi Fialová <gfialova> | |
| Priority: | unspecified | |||
| Version: | 8.4 | CC: | agerstmayr, djez, elpereir, gfialova, jkurik, nathans, nhosoi, pkettman, rmeggins, spetrosi | |
| Target Milestone: | beta | Keywords: | Triaged | |
| Target Release: | 8.6 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | role:metrics | |||
| Fixed In Version: | rhel-system-roles-1.13.0-1.el8 | Doc Type: | Bug Fix | |
| Doc Text: |
.A playbook using the Metrics role completes successfully on multiple runs even if the Grafana `admin` password is changed
Previously, changes to the Grafana `admin` user password after running the Metrics role with the `metrics_graph_service: yes` boolean caused failure on subsequent runs of the Metrics role. This led to failures of playbooks using the Metrics role, and the affected systems were only partially set up for performance analysis. Now, the Metrics role uses the Grafana `deployment` API when it is available and no longer requires knowledge of username or password to perform the necessary configuration actions. As a result, a playbook using the Metrics role completes successfully on multiple runs even if the administrator changes the Grafana `admin` password.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 2041632 (view as bug list) | Environment: | ||
| Last Closed: | 2022-05-10 14:12:08 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1921191 | |||
| Bug Blocks: | 2041632 | |||
@nathans ptal Thanks Brian. Looks like the same issue Marko encountered here: https://github.com/linux-system-roles/metrics/issues/26 What's the latest re your "once the latest Grafana is packaged" comment there Andreas? - is this something we should look into adding to the metric role for 8.5 with the Grafana rebase there? Or would 8.6 be more appropriate? Thanks! > What's the latest re your "once the latest Grafana is packaged" comment there Andreas?
This feature landed in Grafana v7.1, so with the Grafana version in RHEL 8.4 (grafana-7.3.6-2) this feature is available.
I'll start the builds for the final Grafana 7.5.7-2 release (with FIPS approved crypto) for RHEL 8.5 today.
I don't have any capacity to test this for 8.5, but if you have time you can go ahead - please make sure that the PCP Checklist dashboards get imported when the plugin is enabled in that way (I'd expect them to be imported by Grafana plugin provisioning automatically).
(In reply to Andreas Gerstmayr from comment #3) > > What's the latest re your "once the latest Grafana is packaged" comment there Andreas? > > This feature landed in Grafana v7.1, so with the Grafana version in RHEL 8.4 > (grafana-7.3.6-2) this feature is available. > I'll start the builds for the final Grafana 7.5.7-2 release (with FIPS > approved crypto) for RHEL 8.5 today. OK, thanks. > I don't have any capacity to test this for 8.5, but if you have time you can > go ahead - please make sure that the PCP Checklist dashboards get imported > when the plugin is enabled in that way (I'd expect them to be imported by > Grafana plugin provisioning automatically). I also have no time in the short term as we head towards end of 8.5 dev phase. I've set this as an issue for us to return to in 8.6 timeframes. Nathan, Honzo - are you going to work on this for 8.6? If so please provide qa ack, otherwise please strip the ITR. Thanks. Nathan, Honzo - are you going to work on this for 8.6? If so please provide qa ack, otherwise please strip the ITR. Thanks. Heya Peter - let me check in with Andreas and Jan & get back to you there. Tentatively still 'yes' though. (ps: who's Honzo?) This is fixed in ansible-pcp-2.2.2 now - I'll look into updating the metric role once I return from a couple weeks PTO. Thanks Jan ... Rich, I suspect this has actually been complete for some time, since ansible-pcp and the metrics role are fully sync'd up and I think you've pushed through a rebuild of redhat-system-roles since this fix was merged (late Nov, early Dec) - can you confirm? Commit 3e6b4b62c90d in upstream linux-system-roles/metrics is the key commit there. Thanks! (In reply to Nathan Scott from comment #12) > Thanks Jan ... Rich, I suspect this has actually been complete for some > time, since ansible-pcp and the metrics role are fully sync'd up and I think > you've pushed through a rebuild of redhat-system-roles since this fix was > merged (late Nov, early Dec) - can you confirm? Commit 3e6b4b62c90d in > upstream linux-system-roles/metrics is the key commit there. Thanks! Ok. I'm going to assume this is the case. @briasmit please confirm with metrics 1.4.1 upstream Hi Rich, I just tried the latest upstream metrics role and this issue appears to be resolved. I can now change the Grafana password and re-run the role without it failing. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:1896 |
Description of problem: When using the metrics role with "metrics_graph_service: yes", Grafana is installed with the default admin/admin user/password. Upon first login to Grafana, the user is prompted to change the password. If the metrics playbook is re-run, it fails, as it attempts to connect with the admin/admin user/password. Version-Release number of selected component (if applicable): rhel-system-roles-1.0.1-1.el8.noarch How reproducible: Every time Steps to Reproduce: 1. Write playbook call metrics role with "metrics_graph_service: yes" 2. Log in to Grafana and change the default admin password 3. Re-run original playbook Actual results: Playbook Fails: TASK [redhat.rhel_system_roles.private_metrics_subrole_grafana : Ensure graphing service runtime settings are configured] ****************************************************************************************** fatal: [localhost]: FAILED! => {"cache_control": "no-cache", "changed": false, "connection": "close", "content": "{\"message\":\"Invalid username or password\"}", "content_length": "42", "content_type": "application/json; charset=UTF-8", "date": "Wed, 02 Jun 2021 20:23:08 GMT", "elapsed": 0, "expires": "-1", "json": {"message": "Invalid username or password"}, "msg": "Status code was 401 and not [200]: HTTP Error 401: Unauthorized", "pragma": "no-cache", "redirected": false, "status": 401, "url": "http://admin:admin@localhost:3000/api/plugins/performancecopilot-pcp-app/settings", "x_content_type_options": "nosniff", "x_frame_options": "deny", "x_xss_protection": "1; mode=block"} Expected results: Ability to re-run playbook. It would be preferable if the initial Grafana admin password could be set as a role variable. This way the password could be set in an automated manner at install, and the role would also be able to authenticate to Grafana on future runs.