Bug 1967876

Summary: Review Request: perl-Statistics-ChiSquare - How well-distributed is your data?
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Statistics-ChiSquare-1.0000-2.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-16 15:42:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1970378    

Description Paul Howarth 2021-06-04 09:40:39 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Statistics-ChiSquare/branches/fedora/perl-Statistics-ChiSquare.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Statistics-ChiSquare/perl-Statistics-ChiSquare-1.0000-1.fc35.src.rpm

Description:
Suppose you flip a coin 100 times, and it turns up heads 70 times. Is the coin
fair? Suppose you roll a die 100 times, and it shows 30 sixes. Is the die
loaded?

In statistics, the chi-square test calculates how well a series of numbers fits
a distribution. In this module, we only test for whether results fit an even
distribution. It doesn't simply say "yes" or "no". Instead, it gives you a
confidence interval, which sets upper and lower bounds on the likelihood that
the variation in your data is due to chance.

Fedora Account System Username: pghmcfc

This is a new test dependency of perl-Crypt-Random.

Comment 1 Petr Pisar 2021-06-11 10:39:02 UTC
URL and Source0 addresses are Ok.
Source0 archive (SHA-512: 6523c0e44b53835796c5b3f41cb6281413b79c596601a1971b8cb6fc7b2c76fc53ca60642bc96897083d6504ffc0e5ed35b475df4e9264231a5d602d90b3dd35) is original. Ok.
Summary verified from lib/Statistics/ChiSquare.pm. Ok.
Description verified from lib/Statistics/ChiSquare.pm. Ok.

License verified from lib/Statistics/ChiSquare.pm.
FIXME: Add "and CC-BY-SA" to the License tag (lib/Statistics/ChiSquare.pm:447).

TODO: "make %{?_smp_mflags}" and "make pure_install" invocation can be replacved with "%{make_build}" and "%{make_install}" if "perl Makefile.PL" is augmented.

No XS code, noarch Build is Ok.
Build-type dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Statistics-ChiSquare.spec ../SRPMS/perl-Statistics-ChiSquare-1.0000-1.fc35.src.rpm ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm 
========================================================== rpmlint session starts =========================================================
rpmlint: 2.0.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

=========================== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s ==========================
rpmlint is Ok.

 rpm -q -lv -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jun 11 12:31 /usr/share/doc/perl-Statistics-ChiSquare
-rw-r--r--    1 root     root                      514 Oct 21  2016 /usr/share/doc/perl-Statistics-ChiSquare/CHANGELOG
-rw-r--r--    1 root     root                      265 Jul 23  2011 /usr/share/doc/perl-Statistics-ChiSquare/README
drwxr-xr-x    2 root     root                        0 Jun 11 12:31 /usr/share/licenses/perl-Statistics-ChiSquare
-rw-r--r--    1 root     root                     6111 Sep 19  2013 /usr/share/licenses/perl-Statistics-ChiSquare/ARTISTIC.txt
-rw-r--r--    1 root     root                    17987 Sep 19  2013 /usr/share/licenses/perl-Statistics-ChiSquare/GPL2.txt
-rw-r--r--    1 root     root                     3344 Jun 11 12:31 /usr/share/man/man3/Statistics::ChiSquare.3pm.gz
drwxr-xr-x    2 root     root                        0 Jun 11 12:31 /usr/share/perl5/vendor_perl/Statistics
-rw-r--r--    1 root     root                    42967 Oct 21  2016 /usr/share/perl5/vendor_perl/Statistics/ChiSquare.pm
The file permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm | sort -f | uniq -c
      1 perl(Statistics::ChiSquare) = 1.0000
      1 perl-Statistics-ChiSquare = 1.0000-1.fc35
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Statistics-ChiSquare-1.0000-1.fc35.noarch.rpm
Binary dependencies are resolvable. Ok.

The package builds in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=69848542). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX item and consider fixing the TODO item before building this package.
Resolution: Package approved.

Comment 2 Gwyn Ciesla 2021-06-11 15:46:09 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Statistics-ChiSquare

Comment 4 Fedora Update System 2021-06-11 18:19:15 UTC
FEDORA-EPEL-2021-ba941f42b4 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ba941f42b4

Comment 5 Fedora Update System 2021-06-11 18:19:16 UTC
FEDORA-2021-65eae36643 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-65eae36643

Comment 6 Fedora Update System 2021-06-11 18:19:16 UTC
FEDORA-2021-5a3982ec98 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5a3982ec98

Comment 7 Fedora Update System 2021-06-12 01:07:54 UTC
FEDORA-2021-5a3982ec98 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5a3982ec98 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5a3982ec98

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-06-12 01:44:22 UTC
FEDORA-EPEL-2021-9309f7293e has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-9309f7293e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-06-12 01:47:42 UTC
FEDORA-EPEL-2021-ba941f42b4 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ba941f42b4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-06-12 01:57:12 UTC
FEDORA-2021-65eae36643 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-65eae36643 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-65eae36643

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-06-20 01:06:46 UTC
FEDORA-2021-5a3982ec98 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2021-06-20 01:07:11 UTC
FEDORA-2021-65eae36643 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-06-27 01:47:02 UTC
FEDORA-EPEL-2021-ba941f42b4 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2021-06-27 01:51:27 UTC
FEDORA-EPEL-2021-9309f7293e has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.