Bug 1967954
| Summary: | Review Request: ansible-collection-microsoft-sql - The Ansible role to manage Microsoft SQL Server | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergei Petrosian <spetrosi> | ||||||
| Component: | Package Review | Assignee: | Rich Megginson <rmeggins> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | nhosoi, package-review, pcahyna, rmegens, rmeggins | ||||||
| Target Milestone: | --- | Flags: | rmeggins:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-07-20 14:07:23 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 177841 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sergei Petrosian
2021-06-04 14:09:28 UTC
Created attachment 1788989 [details]
srpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=69301461 rpmlint output: [spetrosi@spetrosi ansible-collection-microsoft-sql]$ fedpkg --release f34 lint Failed to get repository name from Git url or pushurl /home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:51: W: macro-in-comment %{archiveurlN} /home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:267: W: macro-in-comment %files /home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:270: W: macro-in-comment %dir /home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:287: W: macro-in-comment %doc ansible-collection-microsoft-sql.src:51: W: macro-in-comment %{archiveurlN} ansible-collection-microsoft-sql.src:267: W: macro-in-comment %files ansible-collection-microsoft-sql.src:270: W: macro-in-comment %dir ansible-collection-microsoft-sql.src:287: W: macro-in-comment %doc ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf ansible-collection-microsoft-sql-collection-artifact.noarch: W: spelling-error %description -l en_US gz -> g, z, gs ansible-collection-microsoft-sql-collection-artifact.noarch: E: description-line-too-long C Collection artifact for ansible-collection-microsoft-sql. This package contains microsoft-sql-0.0.1.tar.gz ansible-collection-microsoft-sql-collection-artifact.noarch: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 14 warnings. Could not execute lint: Failed to execute command. The PR that compares this spec file to the linux-system-roles spec file. The PR is in my personal Git repo, I use it for convenience to track changes made. https://github.com/spetrosi/sql/pull/2/files Hi Rich, Noriko, Pavel, Please review the spec file I created for the RPM that will provide the mssql role. I used the linux-system-roles.spec as a base, I removed most unused code from it and only kept what is relevant to mssql. In comment#2, you can find a link to the PR that you can use to view what has been changed in comparison to linux-system-roles.spec. Thank you I think reviewers can comment and suggest changes right on the PR linked in comment#2 instead of doing it here for convenience. Can you address these rpmlint issues? ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf ansible-collection-microsoft-sql-collection-artifact.noarch: W: spelling-error %description -l en_US gz -> g, z, gs ansible-collection-microsoft-sql-collection-artifact.noarch: E: description-line-too-long C Collection artifact for ansible-collection-microsoft-sql. This package contains microsoft-sql-0.0.1.tar.gz ansible-collection-microsoft-sql-collection-artifact.noarch: W: no-documentation I think the "W: macro-in-comment" ones are ok. (In reply to Rich Megginson from comment #6) > Can you address these rpmlint issues? > > ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir > /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/ > server/.fmf > ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir > /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/ > server/.fmf > ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir > /usr/share/microsoft/sql-server/tests/.fmf > ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir > /usr/share/microsoft/sql-server/tests/.fmf Those .fmf directories are required because without them provision.fmf does not work. And provision.fmf is required to provision a VM with more RAM than usual, which is required for mssql installation. > ansible-collection-microsoft-sql-collection-artifact.noarch: W: > spelling-error %description -l en_US gz -> g, z, gs Gvim highlights Ansible as "incorrect" word on this line, I cannot find any other typo on the line so I think this can be ignored too. > ansible-collection-microsoft-sql-collection-artifact.noarch: E: > description-line-too-long C Collection artifact for > ansible-collection-microsoft-sql. This package contains > microsoft-sql-0.0.1.tar.gz > ansible-collection-microsoft-sql-collection-artifact.noarch: W: > no-documentation These are for the collection_artifact package only meant to be used internally so I think ignoring these two is OK too. Note that rpmlint does not break the build process and there is no need to mark those warnings as ignored anywhere. The same warning appear on the linux-system-roles spec file too. Ok. rpmlint looks good. You can find the latest spec and SRPM here: https://spetros.fedorapeople.org/review_ansible-collection-microsoft-sql/ A request to create the repository for the rpms/ansible-collection-microsoft-sql package: https://pagure.io/releng/fedora-scm-requests/issue/34576 A new request to create the repository for the rpms/ansible-collection-microsoft-sql package: https://pagure.io/releng/fedora-scm-requests/issue/34578 The previous request failed automation because this bug has no assignee so I've assigned myself. limb at https://pagure.io/releng/fedora-scm-requests/issue/34578 says the following: The review is not approved by the assignee of the Bugzilla bug Hence reassigning the bug to Rich because he approved it already. A new request to create the repository for the rpms/ansible-collection-microsoft-sql package: https://pagure.io/releng/fedora-scm-requests/issue/34589 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-microsoft-sql The ansible-collection-microsoft-sql package has been successfully released to Fedora. |