Bug 1967974

Summary:	satellite-change-hostname should handle --no-enable-puppet properly
Product:	Red Hat Satellite	Reporter:	Ian Ballou <iballou>
Component:	satellite-change-hostname	Assignee:	Ewoud Kohl van Wijngaarden <ekohlvan>
Status:	CLOSED ERRATA	QA Contact:	Peter Ondrejka <pondrejk>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.7.0	CC:	egolov
Target Milestone:	6.10.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	katello-4.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-16 14:11:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1957813

Description Ian Ballou 2021-06-04 15:29:54 UTC

Description of problem:

satellite-change-hostname will error out if @scenario_answers['puppet'] is false (https://github.com/theforeman/foreman-packaging/blob/rpm/1.24/packages/katello/katello/hostname-change.rb#L170).  We should skip `delete_puppet_certs` if this is the case.

Note that this isn't currently a supported situation for Satellite, but it should work regardless since it's supported upstream.

Version-Release number of selected component (if applicable):

Satellite 6.7

How reproducible:

Always

Steps to Reproduce:
1. Remove the puppet configuration from satellite-answers.yaml
2. Run satellite-change-hostname
3.

Actual results:

deleting old certs
/usr/share/katello/hostname-change.rb:217:in `delete_puppet_certs': undefined method `[]' for nil:NilClass (NoMethodError)
        from /usr/share/katello/hostname-change.rb:488:in `run'
        from /sbin/satellite-change-hostname:23:in `<main>'

Expected results:

hostname changed successfully

Additional info:

Comment 1 Ian Ballou 2021-06-04 15:36:38 UTC

Created redmine issue https://projects.theforeman.org/issues/32725 from this bug

Comment 3 Bryan Kearney 2021-06-07 15:49:01 UTC

Upstream bug assigned to ekohlvan

Comment 4 Bryan Kearney 2021-06-07 15:49:02 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/32725 has been resolved.

Comment 5 Peter Ondrejka 2021-07-09 09:41:07 UTC

Verified on Satellite 6.10 snap 8

Comment 8 errata-xmlrpc 2021-11-16 14:11:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702