Bug 1968104

Summary: trash-cli: Request for EPEL build
Product: [Fedora] Fedora Reporter: David Auer <dreua>
Component: trash-cliAssignee: David Auer <dreua>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anon.amish, bkircher, terje.rosten
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: trash-cli-0.21.4.18-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-24 17:15:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1968155    
Bug Blocks:    

Description David Auer 2021-06-05 08:29:10 UTC
I'd like to use trash-cli on CentOS, would it be reasonable to build it for EPEL? Happy to help, feel free to add me as co-maintainer if you like.

Cheers

David

Comment 1 David Auer 2021-06-05 09:09:29 UTC
needs python3-unipath by @terjeros.no 

Workaround seems to work:
Install F34 builds: dnf install https://kojipkgs.fedoraproject.org//packages/trash-cli/0.20.11.7/2.fc34/noarch/trash-cli-0.20.11.7-2.fc34.noarch.rpm https://kojipkgs.fedoraproject.org//packages/python-unipath/1.1/13.fc34/noarch/python3-unipath-1.1-13.fc34.noarch.rpm

(Pulls in python39 module)

Change shebang in entry scripts (e.g. /usr/bin/trash) to Python 3.9: `#!/usr/bin/python3.9 -s`

This will not be an issue if properly built against the system's python version.

Comment 2 Ben Kircher 2021-06-05 17:39:40 UTC
Hey there,

> I'd like to use trash-cli on CentOS, would it be reasonable to build it for EPEL? Happy to help, feel free to add me as co-maintainer if you like.

Sure can do. I'm currently AFK until next week, so don't hold your breath :) What's your FAS name?

Comment 3 David Auer 2021-06-06 09:02:52 UTC
FAS: dreua

Thanks!

Comment 4 David Auer 2021-06-08 06:06:21 UTC
Update: Dependencies can now be installed from testing: dnf install python3-unipath --enablerepo=epel-testing

Comment 5 Ben Kircher 2021-06-08 08:08:09 UTC
Update: added user dreua as collaborator to https://src.fedoraproject.org/rpms/trash-cli/. Let me know when there is something missing for you

Comment 6 David Auer 2021-06-08 13:30:35 UTC
Thank you! Branches are already requested, builds should follow shortly...

Comment 7 David Auer 2021-06-08 16:47:28 UTC
"dreua is not a maintainer of the trash-cli package" It looks like you need to either give me maintainer level access or request the branches yourself, thanks!

Branch request tickets:
https://pagure.io/releng/fedora-scm-requests/issue/34463
https://pagure.io/releng/fedora-scm-requests/issue/34464

Request commands:
fedpkg request-branch epel8
fedpkg request-branch epel7

Comment 8 Ben Kircher 2021-06-08 18:32:07 UTC
Ah, thanks. Good to know. Updated your user settings to "admin" and requested the branches.


$ fedpkg request-branch epel8   
https://pagure.io/releng/fedora-scm-requests/issue/34484
$ fedpkg request-branch epel7
https://pagure.io/releng/fedora-scm-requests/issue/34485

Comment 9 David Auer 2021-06-08 21:47:30 UTC
Thanks again! el8 buils fine, but el7 has a problem:

+ /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -s'
Traceback (most recent call last):
  File "setup.py", line 41, in <module>
    main()
  File "setup.py", line 25, in main
    long_description=read_file("README.rst"),
  File "/builddir/build/BUILD/trash-cli-0.21.4.18/trashcli/fs.py", line 83, in read_file
    return f.read()
  File "/usr/lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe7 in position 135: ordinal not in range(128)

https://kojipkgs.fedoraproject.org//work/tasks/5796/69635796/build.log

Does anyone have an idea what this is about and how to fix it? I personally use only CentOS 8 so CentOS 7 would be only a "drive by" update just in case anyone needs it. We may just ignore this issue and be happy with the el8 build.

Comment 10 Ben Kircher 2021-06-09 07:23:02 UTC
+1 on the el8 from me. If you don't need el7… we can always add it later.

Comment 11 Fedora Update System 2021-06-09 12:56:18 UTC
FEDORA-EPEL-2021-b3444f2877 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b3444f2877

Comment 12 Fedora Update System 2021-06-10 01:38:10 UTC
FEDORA-EPEL-2021-b3444f2877 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b3444f2877

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-06-24 17:15:18 UTC
FEDORA-EPEL-2021-b3444f2877 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.