Bug 1968448

Where do we have this info in the cloud?

I see progress only in events in UI.
In REST there is:

    "monitored_operators": [
      {
        "cluster_id": "641f8e78-8058-48fa-bfd1-207dd9077f96",
        "name": "console",
        "operator_type": "builtin",
        "status_updated_at": "0001-01-01T00:00:00.000Z",
        "timeout_seconds": 3600
      },
      {
        "cluster_id": "641f8e78-8058-48fa-bfd1-207dd9077f96",
        "name": "cvo",
        "operator_type": "builtin",
        "status": "progressing",
        "status_info": "Working towards 4.8.0-fc.7: 590 of 676 done (87% complete)",
        "status_updated_at": "2021-06-16T09:24:00.181Z",
        "timeout_seconds": 3600
      }
    ],

Created attachment 1791586 [details]
CVO progress in the UI

Some background about why the assisted-installer is monitoring the clusterversion API
  
While finalizing the installation (once all nodes joined the cluster) the assisted-controller will watch the installation progress by monitoring the clusterversion (equivalent to: `oc get clustgerversion`)
As you can see in the attached image from the UI or in frolland comments above the progress message usually looks like this: 
"Working towards 4.8.0-fc.7: 590 of 676 done (87% complete)"
In some cases clusterversion message might seem like an installation failure e.g.:
"Unable to apply 4.8.0-fc.7: the cluster operator console has not yet successfully rolled out"
or
" Unable to apply 4.8.0-fc.9: the cluster operator authentication is degraded"

While that looks bad it doesn't mean that the installation failed, CVO will keep retrying to apply the desired configuration and monitor the clusteroperators status and eventually (in most cases) reach: "Cluster version is 4.8.0-fc.9"

I think it is desirable to add this information to a condition.
I don't think the misleading messages are an issue while the condition status is set to "progressing".

@atraeger @mhrivnak Thoughts?

It seems reasonable to reflect that progress message into the AgentClusterInstall's "Complete" condition message when its Reason == "InstallationInProgress".

There are two operators here that we monitor, console and CVO, i'm not sure that it will be clear to combine then in the same condition.
Maybe we should have separate condition for each?

The CVO progress should go to complete condition.
console progress can go to a new condition (The console progress is not a must to start with)

type: ConsoleCompleted 
status: unknown - no info (the same as in the example above), false - still installing, failed to install, true - instlaled
reason: unkonwn - NoProgress, false - status, true - status
message: unknown - NoProgress, false - "status info" - status info

sounds good?

I assume we are watching the "Available" condition on the ClusterVersion? And when that becomes "true", we mark our "Complete" condition as true?

For the console, I assume we are also looking at the "Available" condition on its ClusterOperator resource? That seems reasonable to reflect in a separate local condition, especially if its availability is not a requirement for declaring an installation "complete".

CVO status will be part of the "Completed" condition: https://github.com/openshift/assisted-service/pull/2110

Opened an issue to handle other operators: https://issues.redhat.com/browse/MGMT-7099

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759