Bug 1969494

Summary:	[master] no indication for missing debugInfo in AgentClusterInstall
Product:	OpenShift Container Platform	Reporter:	Daniel Erez <derez>
Component:	assisted-installer	Assignee:	Daniel Erez <derez>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	aos-bugs, frolland, mfilanov
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Hive KNI-EDGE-JUKE-4.8 KNI-EDGE-4.8
Fixed In Version:	OCP-Metal-v1.0.23.1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1972530 (view as bug list)		Environment:
Last Closed:	2021-10-18 17:33:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1972530

Description Daniel Erez 2021-06-08 14:13:36 UTC

Description of problem:
When creating an AgentClusterInstall CRD (without a corresponding ClusterDeployment), there is no debugInfo available which is expected as not status is available yet. However, there's no indication in the log for that.

Version-Release number of selected component (if applicable):

How reproducible:
100%

Steps to Reproduce:
1. Create an AgentClusterInstall CRD
2.
3.

Actual results:
No indication that status and debugInfo should not be available yet.

Expected results:
E.g. a warning/info log that the debugInfo (eventsURL/logsURL) would be available once a ClusterDeployment CRD is created.

Additional info:

Comment 1 Fred Rolland 2021-06-10 09:43:32 UTC

Maybe we should add to the SpecSync condition that we miss an object, and set all the others conditions to Unknown

Comment 2 Michael Filanov 2021-06-10 09:49:31 UTC

+1 to SpecSync

Comment 3 Michael Filanov 2021-06-10 09:51:47 UTC

Actually do we even reconcile on this agent cluster install? We are looking at cluster deployment as the main resource.

Comment 4 Michael Filanov 2021-06-14 06:03:35 UTC

When reconcile we are searching for cluster deployment and we don't know the reference to agent cluster install, so it's impossible to set anything on agent cluster install unless we manage to get cluster deployment.

Comment 5 Michael Filanov 2021-06-16 06:54:16 UTC

After few conversations we decided that for this case we can add another controller that will watch only AgentClusterInstall, it will set the sync condition value to failure with a message explaining that the link to cluster deployment is invalid.
It will probably need to set all the other conditions to unknown.

The two cases that it will cover are
1. Cluster deployment is not created yet.
2. User set invalid reference to cluster deployment.

Comment 6 Michael Filanov 2021-06-16 06:55:40 UTC

*** Bug 1969416 has been marked as a duplicate of this bug. ***

Comment 9 errata-xmlrpc 2021-10-18 17:33:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759